Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve assembly-level experimental warnings #4395

Closed
RussKie opened this issue Sep 13, 2023 · 1 comment
Closed

Resolve assembly-level experimental warnings #4395

RussKie opened this issue Sep 13, 2023 · 1 comment
Labels
area-fundamentals

Comments

@RussKie
Copy link
Member

RussKie commented Sep 13, 2023

As a result of updating to the newer SDK, we have hundreds of TBD warnings:

error TBD: (NETCORE_ENGINEERING_TELEMETRY=Build) 'Microsoft.Extensions.Options.Contextual.IOptionsContext' is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed. (https://aka.ms/dotnet-extensions-warnings/TBD)

These are the result of

extensions/Directory.Build.targets

Lines 56 to 62 in 80f8c70

<ItemGroup Condition="'$(Stage)' == 'dev' AND '$(OutputType)' != 'Exe' AND '$(Api)' != 'false'">
<AssemblyAttribute Include="System.Diagnostics.CodeAnalysis.ExperimentalAttribute">
<_Parameter1>TBD</_Parameter1>
<_Parameter2>UrlFormat = "https://aka.ms/dotnet-extensions-warnings/{0}"</_Parameter2>
<_Parameter2_IsLiteral>true</_Parameter2_IsLiteral>
</AssemblyAttribute>
</ItemGroup>

We need to generalise how the assembly-level attribute is applied based on the workstream. We'll need a mapping between workstreams and the experiment areas listed in https://github.com/dotnet/extensions/blob/main/docs/list-of-diagnostics.md.
@RussKie RussKie mentioned this issue Sep 13, 2023
Merged
RussKie added a commit to RussKie/extensions that referenced this issue Sep 13, 2023
@RussKie
Suppress TBD warnings, see dotnet#4395
71550f3
RussKie added a commit that referenced this issue Sep 13, 2023
@RussKie
Update TFMs (#4394)
b8b7166 
* Revise supported TFMs

* Drop support for .NET Core 3.1
* Add support for .NET 6.0
* Run tests for only supported TFMs - i.e., net462;net6.0;net8.0

* warning IDE0028: Collection initialization can be simplified (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0028)

* Suppress TBD warnings, see #4395

* error CS0618: 'HttpRequestMessage.Properties' is obsolete: 'HttpRequestMessage.Properties has been deprecated. Use Options instead.'

* Fix tests

* warning NETSDK1212: IsTrimmable is not supported for the target framework
@geeknoid
Copy link
Member

This was taken care.

@ghost ghost removed the untriaged label Nov 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-fundamentals
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RussKie @geeknoid