Improve JsonSchemaExporter trimmer safety. #5591
Conversation
There was a problem hiding this comment.
I think the current changes look better than what we had before. I think there is something that can be done in the future about that DynamicallyAccessedMemberTypes.All reference. But that shouldn't block this PR.
I see there are still 3 UnconditionalSuppressMessage attributes in this file.
The 2 regarding NullableAttribute and NullableContextAttribute don't look correct to me. The AOT compiler could trim the field metadata for these types, in theory. Maybe it would be better to use GetCustomAttributesData instead.
For the one regarding GetGenericMemberDefinition, I think we could use GetMemberWithSameMetadataDefinitionAs to remove the suppression.
It would be better to use |
… schema generation. (#109424) * Add annotations and regression testing for members accessed by legacy schema generation. * Update src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonPropertyInfo.cs * Incorporate feedback from dotnet/extensions#5591
* Improve JsonSchemaExporter trimmer safety. * Remove var * Address feedback. * Remove DynamicallyAccessedMemberTypes.All * Extract reflection helpers into separate file and remove a number of warning suppressions. * Re-enable failing tests that were patched in .NET 9
Improves the private reflection code used by the
JsonSchemaExporterpolyfill so that trimmer safety is improved.Microsoft Reviewers: Open in CodeFlow