Fix METGEN004 error message: print return type in ErrorInvalidMethodReturnType
#6905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the METGEN004 error message to include the actual return type when reporting invalid method return types in the metrics generator. The change improves diagnostics by displaying the problematic return type (e.g., void, object, int) instead of just the method name.
- Updates error diagnostic to show the return type using minimally qualified format
- Adds test coverage to verify the error message includes the return type
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Generators/Microsoft.Gen.Metrics/Parser.cs | Modified error diagnostic to include return type in message instead of method name |
| test/Generators/Microsoft.Gen.Metrics/Unit/ParserTests.cs | Added test assertion to verify error message contains the return type |
dariusclay
approved these changes
Oct 13, 2025
This was referenced Nov 11, 2025
Merged
Merged
Merged
Merged
Open
Open
This was referenced Nov 12, 2025
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alt impls:
returnType.Namewould returnVoid,Object,Int32instead ofvoid,objectandint.SymbolDisplayFormat.MinimallyQualifiedFormatwould return the fully qualified name (i.e.Namespace.OuterClass.InnerClass).Fixes #6719
Microsoft Reviewers: Open in CodeFlow