Add Workstream, Stage, and PackageValidationBaselineVersion metadata to ServiceDiscovery libraries #6919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: joperezr <13854455+joperezr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update .csproj files to add Workstream and Stage metadata
Add Workstream and Stage metadata properties to ServiceDiscovery libraries
Oct 14, 2025
Copilot finished work on behalf of
joperezr
October 14, 2025 18:40
joperezr
approved these changes
Oct 14, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds required <Workstream> and <Stage> metadata properties to all ServiceDiscovery library project files to ensure proper build and packaging infrastructure support.
- Adds
<Workstream>ServiceDiscovery</Workstream>and<Stage>normal</Stage>properties to four ServiceDiscovery libraries - Follows the established pattern used by other library workstreams in the repository
- Enables correct categorization and processing by the build infrastructure
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Microsoft.Extensions.ServiceDiscovery.csproj | Added metadata PropertyGroup for core ServiceDiscovery library |
| Microsoft.Extensions.ServiceDiscovery.Yarp.csproj | Added metadata PropertyGroup for YARP integration library |
| Microsoft.Extensions.ServiceDiscovery.Dns.csproj | Added metadata PropertyGroup for DNS provider library |
| Microsoft.Extensions.ServiceDiscovery.Abstractions.csproj | Added metadata PropertyGroup for abstractions library |
Member
|
@copilot in order to fix the build issues, please also add the following property to all 4 projects: |
Co-authored-by: joperezr <13854455+joperezr@users.noreply.github.com>
Contributor
Author
Added |
Copilot
AI
changed the title
Add Workstream and Stage metadata properties to ServiceDiscovery libraries
Add Workstream, Stage, and PackageValidationBaselineVersion metadata to ServiceDiscovery libraries
Oct 14, 2025
Copilot finished work on behalf of
joperezr
October 14, 2025 18:59
eerhardt
reviewed
Oct 14, 2025
...ions.ServiceDiscovery.Abstractions/Microsoft.Extensions.ServiceDiscovery.Abstractions.csproj
Show resolved
Hide resolved
eerhardt
approved these changes
Oct 14, 2025
…ojects Replace PackageIconFullPath with StrongNameKeyId and add MinCodeCoverage/MinMutationScore properties in ServiceDiscovery, ServiceDiscovery.Abstractions, ServiceDiscovery.Dns, and ServiceDiscovery.Yarp .csproj files. Also add empty .json placeholder files for ServiceDiscovery and ServiceDiscovery.Abstractions.
eerhardt
reviewed
Oct 14, 2025
...ions.ServiceDiscovery.Abstractions/Microsoft.Extensions.ServiceDiscovery.Abstractions.csproj
Show resolved
Hide resolved
joperezr
approved these changes
Oct 15, 2025
This was referenced Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the required
<Workstream>,<Stage>, and<PackageValidationBaselineVersion>metadata properties to all ServiceDiscovery library.csprojfiles to ensure packages are built and generated correctly.Changes
Added a new
<PropertyGroup>section to each ServiceDiscovery project containing:Affected Projects
Microsoft.Extensions.ServiceDiscovery.AbstractionsMicrosoft.Extensions.ServiceDiscoveryMicrosoft.Extensions.ServiceDiscovery.DnsMicrosoft.Extensions.ServiceDiscovery.YarpThese metadata properties are used by the build and packaging infrastructure to properly categorize and process the ServiceDiscovery libraries, following the same pattern used by other library workstreams in this repository (AI, Telemetry, Resilience, etc.). The
PackageValidationBaselineVersionis set to 9.5.1 to fix build validation issues.Fixes #6868
Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Microsoft Reviewers: Open in CodeFlow