From afd181daf0cba31cdfd33a691dad1711f9a72a22 Mon Sep 17 00:00:00 2001 From: Tomas Grosup Date: Thu, 11 Dec 2025 14:07:49 +0100 Subject: [PATCH 1/3] Update .NET SDK version in global.json --- global.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/global.json b/global.json index d3eb757362..e6db33140a 100644 --- a/global.json +++ b/global.json @@ -1,6 +1,6 @@ { "sdk": { - "version": "10.0.100-rc.2.25502.107", + "version": "10.0.100", "allowPrerelease": true, "paths": [ ".dotnet", @@ -9,7 +9,7 @@ "errorMessage": "The .NET SDK could not be found, please run ./eng/common/dotnet.sh." }, "tools": { - "dotnet": "10.0.100-rc.2.25502.107", + "dotnet": "10.0.100", "vs": { "version": "18.0", "components": [ From 342dba1a36e73210c9eb8dedcbb8e684289c1338 Mon Sep 17 00:00:00 2001 From: Tomas Grosup Date: Thu, 11 Dec 2025 15:17:20 +0000 Subject: [PATCH 2/3] use DOTNET_ROOT env var to locate the sdk , local .dotnet might not always be needed --- .../DependencyManagerInteractiveTests.fs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/FSharp.Compiler.Private.Scripting.UnitTests/DependencyManagerInteractiveTests.fs b/tests/FSharp.Compiler.Private.Scripting.UnitTests/DependencyManagerInteractiveTests.fs index bee85322a2..7073a9aca7 100644 --- a/tests/FSharp.Compiler.Private.Scripting.UnitTests/DependencyManagerInteractiveTests.fs +++ b/tests/FSharp.Compiler.Private.Scripting.UnitTests/DependencyManagerInteractiveTests.fs @@ -69,7 +69,7 @@ type DependencyManagerInteractiveTests() = *) static member SdkDirOverrideTestData = [| [| None |] - [| Path.Combine(__SOURCE_DIRECTORY__, "..", "..", ".dotnet", "sdk") + [| Path.Combine(Environment.GetEnvironmentVariable("DOTNET_ROOT"), "sdk") |> Directory.GetDirectories |> Seq.head |> Some |] From e21c4cc3eb4b623b40bb66ff1c7263e527fe1b90 Mon Sep 17 00:00:00 2001 From: Tomas Grosup Date: Fri, 12 Dec 2025 09:19:56 +0000 Subject: [PATCH 3/3] SdkDirOverrideTestData check --- .../DependencyManagerInteractiveTests.fs | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/tests/FSharp.Compiler.Private.Scripting.UnitTests/DependencyManagerInteractiveTests.fs b/tests/FSharp.Compiler.Private.Scripting.UnitTests/DependencyManagerInteractiveTests.fs index 7073a9aca7..2cd2dcc8bc 100644 --- a/tests/FSharp.Compiler.Private.Scripting.UnitTests/DependencyManagerInteractiveTests.fs +++ b/tests/FSharp.Compiler.Private.Scripting.UnitTests/DependencyManagerInteractiveTests.fs @@ -67,13 +67,16 @@ type DependencyManagerInteractiveTests() = let errors = script.Eval(code) |> getErrors Assert.Contains(message, errors |> Array.map(fun e -> e.Message)) *) - static member SdkDirOverrideTestData = [| - [| None |] - [| Path.Combine(Environment.GetEnvironmentVariable("DOTNET_ROOT"), "sdk") - |> Directory.GetDirectories - |> Seq.head - |> Some |] - |] + static member SdkDirOverrideTestData = + [| + yield [| None |] + let dotnetRoot = Environment.GetEnvironmentVariable("DOTNET_ROOT") + if not (isNull dotnetRoot) then + yield [| Path.Combine(dotnetRoot, "sdk") + |> Directory.GetDirectories + |> Seq.head + |> Some |] + |] [] []