Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to find previous non-empty line for correct indentation #1986

Merged
merged 1 commit into from
Dec 14, 2016

Conversation

dungpa
Copy link
Contributor

@dungpa dungpa commented Dec 10, 2016

Fix #1980.

@abelbraaksma
Copy link
Contributor

abelbraaksma commented Dec 10, 2016

Does this also fix (in part or whole) #1588?

@dungpa
Copy link
Contributor Author

dungpa commented Dec 10, 2016

@abelbraaksma It should fix #1588.
Looking at the code, I don't think Visual F# Tools has supported Smart Indent, whatever it means.

@KevinRansom
Copy link
Member

@dungpa
If you want to force a pr to be re-run through the ci.

Type

@dotnet-bot test this please

This will not restart appveyor, but will run all of the other ci scenarios.

Kevin

else
match previousLine.Text.[previousLine.Start + column] with
| ' ' -> loop (column + 1) (spaces + 1)
| '\t' -> loop (column + 1) (((spaces / tabSize) + 1) * tabSize)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we allow \t to appear in an F# source file in the editor? is it not immediately turned into spaces?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm perhaps we do in the not light mode. never mind.

@dungpa
Copy link
Contributor Author

dungpa commented Dec 13, 2016

@KevinRansom Thanks for the tip.

@KevinRansom
Copy link
Member

@dungpa
Thank you for taking care of this

Kevin

@KevinRansom KevinRansom merged commit 9984b9c into dotnet:master Dec 14, 2016
@dungpa dungpa deleted the indentation branch December 14, 2016 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants