Revert "Remove dependency on FSharp.LanguageService (#4108)" #4128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 351d06b.
cartermp
changed the title
cartermp
changed the title
Contributor
Author
Contributor
|
What about at least single test which checks that files in old style projects are not plane text? I’m surprised that missing of such a fundamental functionality has passed all the existing tests. |
Contributor
Author
|
I'd have to do that in #4129, not this one. I can see if it's possible to do it in a sane way. I don't trust the old tests very much. So much of it is about ensuring that dead code paths work. |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
…otnet#4128) This reverts commit 351d06b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #4108 until I can figure out what's up with legacy projects
Despite being convinced that I validated .NET Framework projects, source files are plaintext (though scripts aren't) with the change in #4108.