Skip to content

Conversation

@ncave
Copy link
Contributor

@ncave ncave commented May 31, 2019

Fixed build tools paths to match fcs/build.fsx.

cartermp
cartermp previously approved these changes May 31, 2019
Copy link
Member

@brettfo brettfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should stay because lex/yacc are specifically copied to artifacts/Bootstrap here for Windows and here for Linux.

@ncave
Copy link
Contributor Author

ncave commented May 31, 2019

@brettfo Should fcs/build.fsx be fixed to use artifacts/Bootstrap too, for consistency?

@baronfel
Copy link
Member

This is a good catch because I was working on mono builds of the compiler and build libraries on my fork and ran into the same problem.

@KevinRansom
Copy link
Contributor

@ncave,
we will need a different fix for this. Either the fcs build you are using, needs to use lex from Bootstrap or it needs to take responsibility for building/deploying Lex/Yacc itself.

Thanks

kevin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants