Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CentOS Stream 9 container to CI matrix #12955

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Add CentOS Stream 9 container to CI matrix #12955

merged 1 commit into from
Feb 15, 2022

Conversation

omajid
Copy link
Member

@omajid omajid commented Jan 4, 2022

No description provided.

@omajid
Copy link
Member Author

omajid commented Jan 5, 2022

@MichaelSimons sorry if this is a repeat, but does this PR need to be merged, and then wait for a nightly build for us to be able to see results? Do you know where I can see the results for any previous nightly runs?

@MichaelSimons
Copy link
Member

@omajid - you would have to merge this to see the result because this is not run as part of PR validation. A suggestion would be to move it outside of the ne(pullrequest) check to validate it in PR validation once and then if it passes, move it back to where you have it.

@MichaelSimons
Copy link
Member

Do you know where I can see the results for any previous nightly runs?

You can navigate to the public builds from the readme - https://github.com/dotnet/installer/tree/release/6.0.1xx#build-status. From a public installer build, go to the Associated Pipelines tab to see the corresponding dotnet-installer-source-build-tarball-build. The public installer build produces the tarball artifact that is then built/tested in the tarball-build.

@omajid
Copy link
Member Author

omajid commented Jan 5, 2022

Thanks!

@omajid omajid force-pushed the 6.0.1xx-source-build-add-cento-stream-9 branch 2 times, most recently from 4791e2f to 879df81 Compare January 5, 2022 21:04
@omajid
Copy link
Member Author

omajid commented Jan 6, 2022

A test needs pkill to stop the ASP.NET Core server, but pkill is not installed in the container image. Opened dotnet/dotnet-buildtools-prereqs-docker#557 to fix that.

@omajid omajid force-pushed the 6.0.1xx-source-build-add-cento-stream-9 branch 3 times, most recently from 0eb8e71 to 1e6fc64 Compare January 11, 2022 15:28
@omajid
Copy link
Member Author

omajid commented Jan 11, 2022

Any idea how to get logs from the aspnetcore build that hangs?

@MichaelSimons
Copy link
Member

One thing to try is to set a timeout on the Build Tarball steps that is smaller than the containing job's timeout. When doing this, the build step should timeout yet the job hasn't timed out yet allowing the subsequent jobs to run which gather and publish the logs.

@omajid omajid force-pushed the 6.0.1xx-source-build-add-cento-stream-9 branch 2 times, most recently from 8481a91 to fe9a0dd Compare January 13, 2022 15:19
@omajid
Copy link
Member Author

omajid commented Jan 14, 2022

Build hangs at this command:

                  "/tarball/src/aspnetcore.4e7d976438b0fc17f435804e801d5d68d193ec33/artifacts/source-build/self/package-cache/microsoft.netcore.app.crossgen2.linux-x64/6.0.1/tools/crossgen2" --targetarch:x64 --targetos:linux -O @"/tarball/src/aspnetcore.4e7d976438b0fc17f435804e801d5d68d193ec33/artifacts/source-build/self/src/artifacts/obj/Microsoft.AspNetCore.App.Runtime/Release/net6.0/linux-x64/crossgen/PlatformAssembliesPathsCrossgen2.rsp" --perfmap --perfmap-format-version:1 --perfmap-path:"/tarball/src/aspnetcore.4e7d976438b0fc17f435804e801d5d68d193ec33/artifacts/source-build/self/src/artifacts/bin/Microsoft.AspNetCore.App.Runtime/Release/net6.0/linux-x64/" -o:"/tarball/src/aspnetcore.4e7d976438b0fc17f435804e801d5d68d193ec33/artifacts/source-build/self/src/artifacts/bin/Microsoft.AspNetCore.App.Runtime/Release/net6.0/linux-x64/Microsoft.Extensions.Caching.Abstractions.dll" "/tarball/src/aspnetcore.4e7d976438b0fc17f435804e801d5d68d193ec33/artifacts/source-build/self/package-cache/microsoft.extensions.caching.abstractions/6.0.0/lib/netstandard2.0/Microsoft.Extensions.Caching.Abstractions.dll"

Crossgen2 hanging makes me suspect dotnet/runtime#63314. I am going to wait for that fix to flow in from 6.0.

@omajid omajid force-pushed the 6.0.1xx-source-build-add-cento-stream-9 branch from fe9a0dd to dc1407e Compare January 18, 2022 14:07
@omajid omajid force-pushed the 6.0.1xx-source-build-add-cento-stream-9 branch 4 times, most recently from f86546d to 37e503e Compare February 14, 2022 16:14
@omajid omajid marked this pull request as ready for review February 14, 2022 16:14
@omajid omajid requested a review from a team as a code owner February 14, 2022 16:14
MichaelSimons
MichaelSimons reviewed Feb 15, 2022
View reviewed changes
src/SourceBuild/Arcade/eng/common/templates/job/source-build-run-tarball-build.yml
_BuildArch: x64
_Container: ${{ parameters.centOSStream9Container }}
_ExcludeOmniSharpTests: false
_RunOnline: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a recent , I added the _Platform parameter. Can you please include it with this change? Without it, the msft to sb sdk content comparison tests won't run for this leg.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Done.

@omajid omajid force-pushed the 6.0.1xx-source-build-add-cento-stream-9 branch from 37e503e to b52b466 Compare February 15, 2022 19:19
@MichaelSimons MichaelSimons mentioned this pull request Feb 15, 2022
Merged
@MichaelSimons MichaelSimons enabled auto-merge (squash) February 15, 2022 23:23
@MichaelSimons MichaelSimons merged commit 35abe3c into dotnet:release/6.0.1xx Feb 15, 2022
MichaelSimons added a commit that referenced this pull request Mar 5, 2022
@marcpopMSFT @dotnet-maestro
@lbussell @vseanreesermsft @manodasanW @wtgodbe @MichaelSimons @crummel @omajid
Update 6.0.2xx with the current state of 1xx (#13244)
c3da28f 
* Update .vsts-ci.yml

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20220205.1 (#13179)

[release/6.0.1xx] Update dependencies from dotnet/source-build-reference-packages

* Override Microsoft.Net.Sdk.WindowsDesktop references during source-build in Roslyn (#13093)

* override SDK for Microsoft.Net.Sdk.WindowsDesktop references in roslyn

* add new EmptySdk in the source build tarball

* remove roslyn solution filter patch

* Update dependencies from https://github.com/dotnet/arcade build 20220207.2 (#13186)

Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Arcade.Sdk
 From Version 6.0.0-beta.22102.3 -> To Version 6.0.0-beta.22107.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* [release/6.0.1xx] Windows SDK projection update

* Update asp.net templates (#13193)

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20220210.1 (#13215)

[release/6.0.1xx] Update dependencies from dotnet/source-build-reference-packages

* Add test to compare msft and sb sdk contents (#13153)

* Update to SDK and previously-source-built 6.0.102. (#13221)

* Add CentOS Stream 9 container to CI matrix (#12955)

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20220215.1 (#13229)

[release/6.0.1xx] Update dependencies from dotnet/source-build-reference-packages

* Gather additional smoke test prereqs (#13233)

* Remove bootstrapping for CI builds now that we use CentOS7 previously-source-built (#13232)

* Update Version.Details.xml

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20220303.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 6.0.0-servicing.22151.1 -> To Version 6.0.0-servicing.22153.2

Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Logan Bussell <loganbussell@microsoft.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Sean Reeser <v-seanreeser@microsoft.com>
Co-authored-by: Manodasan Wignarajah <mawign@microsoft.com>
Co-authored-by: William Godbe <wigodbe@microsoft.com>
Co-authored-by: vseanreesermsft <78103370+vseanreesermsft@users.noreply.github.com>
Co-authored-by: Michael Simons <msimons@microsoft.com>
Co-authored-by: Chris Rummel <crummel@microsoft.com>
Co-authored-by: Omair Majid <omajid@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelSimons MichaelSimons MichaelSimons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omajid @MichaelSimons