Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve vscode notebook experience #394

Merged
merged 6 commits into from
May 8, 2020

Conversation

brettfo
Copy link
Member

@brettfo brettfo commented May 8, 2020

Some quick quality-of-life improvements for the VS Code notebook extension:

  • Support DisplayedValueProduced and DisplayedValueUpdated events. This enables better output for #r nuget....
    • N.b., when adding a NuGet package, the kernel returns values with two separate valueId values, one is a GUID, the other is the package name. These values specify what display value to update. Because of this there are separate display events which causes both "Installed" and "Installing" messages to appear. This is a kernel/package restore issue and will have the correct behavior when the valueIds match.
  • In addition to returning formatted values, also return the raw value with a magically-determined mime type. This enables stuff like native JSON output instead of falling back to a formatted string.
    • N.b., VS Code notebook outputs must have a mime type, so we have to provide something. The current magic simply assigns application/json if the returned value is a JSON object, and text/plain otherwise. This can be expanded in the future when necessary.
  • Properly parse and display formatted values with the mime type application/json.
  • (Bonus) Add local build/deploy instructions in README.md

image

@colombod colombod merged commit cd5c092 into dotnet:master May 8, 2020
@brettfo brettfo deleted the package-usability branch May 8, 2020 23:37
@jonsequitur jonsequitur mentioned this pull request May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants