improve vscode notebook experience #394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some quick quality-of-life improvements for the VS Code notebook extension:
DisplayedValueProduced
andDisplayedValueUpdated
events. This enables better output for#r nuget...
.valueId
values, one is a GUID, the other is the package name. These values specify what display value to update. Because of this there are separate display events which causes both "Installed" and "Installing" messages to appear. This is a kernel/package restore issue and will have the correct behavior when thevalueId
s match.In addition to returning formatted values, also return the raw value with a magically-determined mime type. This enables stuff like native JSON output instead of falling back to a formatted string.N.b., VS Code notebook outputs must have a mime type, so we have to provide something. The current magic simply assignsapplication/json
if the returned value is a JSON object, andtext/plain
otherwise. This can be expanded in the future when necessary.application/json
.