From 75d8221d44bb3fb0781f73b4fa53c99da7aa8d06 Mon Sep 17 00:00:00 2001
From: Jonathan Pobst <jonathan.pobst@microsoft.com>
Date: Thu, 14 Sep 2023 18:49:56 -0500
Subject: [PATCH] [JavaTypeSystem] Add JavaFieldModel.ToString(). (#1144)

Context: https://discord.com/channels/732297728826277939/732297837953679412/1151531791069499524

A user reported the following output in their `java-resolution-report.log`:

	The field 'Java.Interop.Tools.JavaTypeSystem.Models.JavaFieldModel' was removed because its name contains a dollar sign.
	The class '[Class] com.google.android.libraries.navigation.internal.aac.ad' was removed because the Java base type 'com.google.android.libraries.navigation.internal.aad.ar<com.google.android.libraries.navigation.internal.aac.af<K, V>>' could not be found.

We should be providing the user with the name of the removed field
rather than the `JavaFieldModel` type name.  To do this, add an
appropriate `JavaFieldModel.ToString ()` method override.
---
 .../JavaModels/JavaFieldModel.cs                          | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/Java.Interop.Tools.JavaTypeSystem/JavaModels/JavaFieldModel.cs b/src/Java.Interop.Tools.JavaTypeSystem/JavaModels/JavaFieldModel.cs
index 2ba84f2da..efbc65a6a 100644
--- a/src/Java.Interop.Tools.JavaTypeSystem/JavaModels/JavaFieldModel.cs
+++ b/src/Java.Interop.Tools.JavaTypeSystem/JavaModels/JavaFieldModel.cs
@@ -43,5 +43,13 @@ public override void Resolve (JavaTypeCollection types, ICollection<JavaUnresolv
 				return;
 			}
 		}
+
+		public override string ToString ()
+		{
+			if (DeclaringType != null)
+				return $"[Field] {DeclaringType.FullName}.{Name}";
+
+			return $"[Field] {Name}";
+		}
 	}
 }