[build] Update more NuGet package versions

Context: https://dev.azure.com/devdiv/DevDiv/_componentGovernance/112013/alert/2979569?typeId=6338203

[Component Governance][0] is a Microsoft internal tool which checks
for known security issues in product dependencies.  It is currently
reporting a defect in Xamarin.Android because Java.Interop restores
the `System.Net.Http` v4.1.0 NuGet package, which contains security
vulnerability [CVE-2018-8292][1]:

	/s/xamarin-android/external/Java.Interop/packages/system.net.http/4.1.0/system.net.http.4.1.0.nupkg
	/s/xamarin-android/external/Java.Interop/packages/system.net.http/4.1.0/system.net.http.nuspec

`System.Net.Http` v4.1.0 isn't actually *used* by Java.Interop or
Xamarin.Android, it's just an implicit NuGet dependency of one of the
various NuGet packages which Java.Interop relies on.

The report is "noise".

That said, we should still avoid "noise" when possible.

Update most NuGet package versions within Java.Interop to the latest
versions provided by `dotnet-public` or `dotnet-eng` (which may not
be the latest versions on NuGet.org).

Exceptions:

  * `Microsoft.Xml.SgmlReader` is not bumped, as the latest version
    introduced an ABI break.

  * `Microsoft.CodeAnalysis.FxCopAnalyzers` v3.3.2 deprecated the
     entire package, introducing additional warnings that I didn't
     want to deal with right now.

  * `protobuf-net` is still not updated, as the latest version causes
     unit test failures; see also PR #878.

I've also moved most of the actual NuGet package version information
into a set of MSBuild properties with a `NuGetPackageVersion` suffix,
so that it will be easier to bump NuGet package versions in the future.

[0]: https://docs.opensource.microsoft.com/tools/cg/
[1]: https://nvd.nist.gov/vuln/detail/CVE-2018-8292

Author: jonpryor

Directory.Build.props

@@ -94,9 +94,32 @@
     <NoWarn>$(NoWarn);CA1307;CA1309;CA1310</NoWarn>
   </PropertyGroup>
 
+  <!-- NuGet Package Versions -->
+  <PropertyGroup>
+    <GitInfoNuGetPackageVersion>2.1.2</GitInfoNuGetPackageVersion>
+    <HtmlAgilityPackNuGetPackageVersion>1.11.30</HtmlAgilityPackNuGetPackageVersion>
+    <IronyNuGetPackageVersion>1.1.0</IronyNuGetPackageVersion>
+    <MicrosoftBuildFrameworkNuGetPackageVersion>16.11.0</MicrosoftBuildFrameworkNuGetPackageVersion>
+    <MicrosoftBuildUtilitiesCoreNuGetPackageVersion>16.11.0</MicrosoftBuildUtilitiesCoreNuGetPackageVersion>
+    <MicrosoftCodeAnalysisCSharpNuGetPackageVersion>3.11.0</MicrosoftCodeAnalysisCSharpNuGetPackageVersion>
+    <MicrosoftCodeAnalysisFxCopAnalyzersNuGetPackageVersion>3.3.0</MicrosoftCodeAnalysisFxCopAnalyzersNuGetPackageVersion>
+    <MicrosoftNETFrameworkReferenceAssembliesNuGetPackageVersion>1.0.2</MicrosoftNETFrameworkReferenceAssembliesNuGetPackageVersion>
+    <MicrosoftNETTestSdkNuGetPackageVersion>16.11.0</MicrosoftNETTestSdkNuGetPackageVersion>
+    <MicrosoftXmlSgmlReaderNuGetPackageVersion>1.8.16</MicrosoftXmlSgmlReaderNuGetPackageVersion>
+    <MonoCSharpNuGetPackageVersion>4.0.0.143</MonoCSharpNuGetPackageVersion>
+    <MonoLinqExpressionsNuGetPackageVersion>2.0.0</MonoLinqExpressionsNuGetPackageVersion>
+    <MonoOptionsNuGetPackageVersion>6.12.0.148</MonoOptionsNuGetPackageVersion>
+    <MonoTerminalNuGetPackageVersion>5.4.2</MonoTerminalNuGetPackageVersion>
+    <NUnit3TestAdapterNuGetPackageVersion>4.0.0</NUnit3TestAdapterNuGetPackageVersion>
+    <NUnitConsoleRunnerNuGetPackageVersion>3.12.0</NUnitConsoleRunnerNuGetPackageVersion>
+    <NunitNuGetPackageVersion>3.13.2</NunitNuGetPackageVersion>
+    <ProtobufNetNuGetPackageVersion>2.4.4</ProtobufNetNuGetPackageVersion>
+    <XliffTasksNuGetPackageVersion>1.0.0-beta.20420.1</XliffTasksNuGetPackageVersion>
+  </PropertyGroup>
+
   <!-- Add Roslyn analyzers NuGet to all projects -->
   <ItemGroup Condition=" '$(DisableRoslynAnalyzers)' != 'True' ">
-    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.0">
+    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="$(MicrosoftCodeAnalysisFxCopAnalyzersNuGetPackageVersion)">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>

build-tools/Java.Interop.BootstrapTasks/Java.Interop.BootstrapTasks.csproj

@@ -7,8 +7,8 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Build.Framework" Version="16.5.0" />
-    <PackageReference Include="Microsoft.Build.Utilities.Core" Version="16.5.0" />
+    <PackageReference Include="Microsoft.Build.Framework" Version="$(MicrosoftBuildFrameworkNuGetPackageVersion)" />
+    <PackageReference Include="Microsoft.Build.Utilities.Core" Version="$(MicrosoftBuildUtilitiesCoreNuGetPackageVersion)" />
   </ItemGroup>
 
   <ItemGroup>

build-tools/jnienv-gen/jnienv-gen.csproj

@@ -12,6 +12,6 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" PrivateAssets="All" Version="1.0.0" />
+    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" PrivateAssets="All" Version="$(MicrosoftNETFrameworkReferenceAssembliesNuGetPackageVersion)" />
   </ItemGroup>
 </Project>

build-tools/scripts/RunNUnitTests.targets

@@ -5,7 +5,7 @@
     <_TopDir>$(MSBuildThisFileDirectory)..\..</_TopDir>
     <_Runtime Condition=" '$(RUNTIME)' != '' ">$(RUNTIME)</_Runtime>
     <_Runtime Condition=" '$(RUNTIME)' == '' And '$(OS)' != 'Windows_NT' ">mono --debug</_Runtime>
-    <_NUnit>$(_Runtime) packages\nunit.consolerunner\3.11.1\tools\nunit3-console.exe</_NUnit>
+    <_NUnit>$(_Runtime) packages\nunit.consolerunner\$(NUnitConsoleRunnerNuGetPackageVersion)\tools\nunit3-console.exe</_NUnit>
     <_Run Condition=" '$(RUN)' != '' ">--run=&quot;$(RUN)&quot;</_Run>
   </PropertyGroup>
   <Import

build-tools/scripts/VersionInfo.targets

@@ -8,7 +8,7 @@
     <GitThisAssembly>false</GitThisAssembly>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="GitInfo" Version="2.1.2" PrivateAssets="all" />
+    <PackageReference Include="GitInfo" PrivateAssets="all" Version="$(GitInfoNuGetPackageVersion)" />
   </ItemGroup>
 
   <Target Name="GenerateVersionInfo"

samples/Hello/Hello.csproj

@@ -12,7 +12,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" PrivateAssets="All" Version="1.0.0" />
+    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" PrivateAssets="All" Version="$(MicrosoftNETFrameworkReferenceAssembliesNuGetPackageVersion)" />
   </ItemGroup>
 
   <ItemGroup>

src/Java.Interop.Localization/Java.Interop.Localization.csproj

@@ -11,7 +11,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="XliffTasks" Version="1.0.0-beta.20420.1" />
+    <PackageReference Include="XliffTasks" Version="$(XliffTasksNuGetPackageVersion)" />
   </ItemGroup>
 
   <ItemGroup>

src/Java.Interop.Tools.JavaSource/Java.Interop.Tools.JavaSource.csproj

@@ -15,7 +15,7 @@
     <Compile Include="..\utils\NullableAttributes.cs" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Irony" Version="1.1.0" />
+    <PackageReference Include="Irony" Version="$(IronyNuGetPackageVersion)" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\Xamarin.Android.Tools.ApiXmlAdjuster\Xamarin.Android.Tools.ApiXmlAdjuster.csproj" />

src/Xamarin.Android.Tools.AnnotationSupport/Xamarin.Android.Tools.AnnotationSupport.csproj

@@ -9,7 +9,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="HtmlAgilityPack" Version="1.11.24" />
+    <PackageReference Include="HtmlAgilityPack" Version="$(HtmlAgilityPackNuGetPackageVersion)" />
   </ItemGroup>
 
 </Project>

src/Xamarin.Android.Tools.Bytecode/Xamarin.Android.Tools.Bytecode.csproj

@@ -11,7 +11,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="protobuf-net" Version="2.4.4" />
+    <PackageReference Include="protobuf-net" Version="$(ProtobufNetNuGetPackageVersion)" />
   </ItemGroup>
 
 </Project>