[build] Import $(MSBuildProjectDirectory).override.props #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit b6431ac introduced support for `Configuration.Override.props`, which eventually allowed overriding the `external/xamarin-android-tools` path via the `$(XamarinAndroidToolsDirectory)` MSBuild property in commit 32f0c9c. A problem with this approach is that it requires that the host repo create the `Java.Interop/Configuration.Override.props` file before running `make -C …/Java.Interop prepare`. This can be simplified: update `Directory.Build.props` so that it will also `<Import/>` the file `$(MSBuildProjectDirectory).override.props`. [`$(MSBuildProjectDirectory)`][0] is: > The absolute path of the directory where the project file is > located, for example `C:\MyCompany\MyProduct`. > > Do not include the final backslash on this property. The "Do not" is grammatically odd, as it's set by MSBuild. It *does not* include a final backslash. This means that we can place the `.override.props` file in the directory containing the Java.Interop checkout, with a name that matches the git submodule directory name: external/my-Java.Interop-checkout # git submodule to xamarin/Java.Interop external/my-Java.Interop-checkout.override.props # now automatically imported [0]: https://docs.microsoft.com/en-us/visualstudio/msbuild/msbuild-reserved-and-well-known-properties?view=vs-2019
jonathanpeppers
approved these changes
Aug 24, 2021
jpobst
pushed a commit
that referenced
this pull request
Sep 30, 2021
Commit b6431ac introduced support for `Configuration.Override.props`, which eventually allowed overriding the `external/xamarin-android-tools` path via the `$(XamarinAndroidToolsDirectory)` MSBuild property in commit 32f0c9c. A problem with this approach is that it requires that the host repo create the `Java.Interop/Configuration.Override.props` file before running `make -C …/Java.Interop prepare`. This can be simplified: update `Directory.Build.props` so that it will also `<Import/>` the file `$(MSBuildProjectDirectory).override.props`. [`$(MSBuildProjectDirectory)`][0] is: > The absolute path of the directory where the project file is > located, for example `C:\MyCompany\MyProduct`. > > Do not include the final backslash on this property. The "Do not" is grammatically odd, as it's set by MSBuild. It *does not* include a final backslash. This means that we can place the `.override.props` file in the directory containing the Java.Interop checkout, with a name that matches the git submodule directory name: external/my-Java.Interop-checkout # git submodule to xamarin/Java.Interop external/my-Java.Interop-checkout.override.props # now automatically imported [0]: https://docs.microsoft.com/en-us/visualstudio/msbuild/msbuild-reserved-and-well-known-properties?view=vs-2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit b6431ac introduced support for
Configuration.Override.props,which eventually allowed overriding the
external/xamarin-android-toolspath via the
$(XamarinAndroidToolsDirectory)MSBuild property incommit 32f0c9c.
A problem with this approach is that it requires that the host repo
create the
Java.Interop/Configuration.Override.propsfile beforerunning
make -C …/Java.Interop prepare.This can be simplified: update
Directory.Build.propsso that itwill also
<Import/>the file$(MSBuildProjectDirectory).override.props.$(MSBuildProjectDirectory)is:The "Do not" is grammatically odd, as it's set by MSBuild.
It does not include a final backslash.
This means that we can place the
.override.propsfile in thedirectory containing the Java.Interop checkout, with a name that
matches the git submodule directory name: