Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for dotnet/runtime#73048 #2977

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Conversation

MichalStrehovsky
Copy link
Member

Running dataflow analysis on the added test takes about 20 seconds. Double the number of yield returns and it will take several minutes.

In the runtime repo we're running into this on https://github.com/dotnet/runtime/blob/main/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTestData.cs (method SerializableObjects()). That one has even more yield returns and I lost patience waiting for it to finish.

Running dataflow analysis on the added test takes about 20 seconds. Double the number of `yield returns` and it will take several minutes.

In the runtime repo we're running into this on https://github.com/dotnet/runtime/blob/main/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTestData.cs (method `SerializableObjects()`). That one has even more `yield returns` and I lost patience waiting for it to finish.
@MichalStrehovsky
Copy link
Member Author

@sbomer is there something we can do to make this finish in more reasonable time?

@sbomer sbomer merged commit c42e3cb into dotnet:main Aug 17, 2022
@MichalStrehovsky MichalStrehovsky deleted the nonlinear branch August 17, 2022 18:43
agocke pushed a commit to dotnet/runtime that referenced this pull request Nov 16, 2022
Running dataflow analysis on the added test takes about 20 seconds. Double the number of `yield returns` and it will take several minutes.

In the runtime repo we're running into this on https://github.com/dotnet/runtime/blob/main/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTestData.cs (method `SerializableObjects()`). That one has even more `yield returns` and I lost patience waiting for it to finish.

Commit migrated from dotnet/linker@c42e3cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants