[net11.0] [dotnet] Don't allow setting PublishTrimmed to any value. #24335

rolfbjarne · 2025-11-28T18:59:29Z

This is a workaround for dotnet/runtime#108269, where setting PublishTrimmed=true causes problems (and this is affecting and confusing more and more people).

This is a workaround dotnet/runtime#108269, where setting PublishTrimmed=true causes problems.

Copilot

Pull request overview

This PR modifies the build system to disallow users from setting the PublishTrimmed property to any value (including true and false), as a workaround for dotnet/runtime#108269 where setting PublishTrimmed=true causes problems. Users must instead use platform-specific properties like LinkMode (macOS) or MtouchLink (iOS/tvOS/Mac Catalyst) to configure trimming behavior.

Key Changes

Updated error checking in _ComputePublishTrimmed target to reject any explicit PublishTrimmed value instead of just non-true values
Modified test cases to validate that both PublishTrimmed=false and PublishTrimmed=true now produce build errors
Updated error message to clarify that setting PublishTrimmed to any value is not supported

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
dotnet/targets/Xamarin.Shared.Sdk.targets	Modified `_ComputePublishTrimmed` target to error when `PublishTrimmed` is set to any value, moved error check before property calculation
tests/dotnet/UnitTests/PublishTrimmedTest.cs	Added test cases for both `PublishTrimmed=true` and `PublishTrimmed=false`, updated error message assertion to match new behavior

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

tests/dotnet/UnitTests/PublishTrimmedTest.cs

dotnet/targets/Xamarin.Shared.Sdk.targets

vs-mobiletools-engineering-service2 · 2025-12-05T17:06:17Z

💻 [CI Build #dafc682] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: dafc6822716ee9d581e0409cca9eaf1ecee5b3b9 [PR build]

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

vs-mobiletools-engineering-service2 · 2025-12-08T17:47:31Z

✅ [CI Build #c9c6484] Build passed (Build packages) ✅

Pipeline on Agent
Hash: c9c64847e6e8341bb0785a5d95259728e5467130 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-08T17:48:41Z

✅ [PR Build #c9c6484] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: c9c64847e6e8341bb0785a5d95259728e5467130 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-08T18:14:47Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: c9c64847e6e8341bb0785a5d95259728e5467130 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-08T19:04:11Z

✅ [CI Build #c9c6484] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: c9c64847e6e8341bb0785a5d95259728e5467130 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-08T19:14:40Z

💻 [CI Build #c9c6484] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: c9c64847e6e8341bb0785a5d95259728e5467130 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-08T19:18:27Z

💻 [CI Build #c9c6484] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: c9c64847e6e8341bb0785a5d95259728e5467130 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-08T19:18:57Z

💻 [CI Build #c9c6484] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: c9c64847e6e8341bb0785a5d95259728e5467130 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-08T19:24:18Z

💻 [CI Build #c9c6484] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: c9c64847e6e8341bb0785a5d95259728e5467130 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-08T20:14:47Z

🔥 [CI Build #c9c6484] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

2 tests crashed, 3 tests failed, 109 tests passed.

Failures

❌ generator tests

1 tests failed, 4 tests passed.

Roslyn Transformer tests: TimedOut (Execution timed out after 30 minutes.)

Html Report (VSDrops) Download

❌ monotouch tests (iOS)

1 tests failed, 8 tests passed.

monotouch-test/iOS - simulator/Debug (interpreter): Failed

Html Report (VSDrops) Download

❌ monotouch tests (MacCatalyst)

1 tests failed, 10 tests passed.

monotouch-test/Mac Catalyst/Release (managed static registrar, all optimizations): Failed (Test run failed.
Tests run: 3436 Passed: 3210 Inconclusive: 13 Failed: 1 Ignored: 225)

Html Report (VSDrops) Download

❌ xcframework tests

🔥 Failed catastrophically on VSTS: test results - xcframework (no summary found).

Html Report (VSDrops) Download

❌ xtro tests

🔥 Failed catastrophically on VSTS: test results - xtro (no summary found).

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: c9c64847e6e8341bb0785a5d95259728e5467130 [PR build]

[net11.0] [dotnet] Don't allow setting PublishTrimmed to any value.

0dae187

This is a workaround dotnet/runtime#108269, where setting PublishTrimmed=true causes problems.

rolfbjarne enabled auto-merge (squash) November 28, 2025 18:59

rolfbjarne requested a review from Copilot November 28, 2025 18:59

Copilot started reviewing on behalf of rolfbjarne November 28, 2025 19:00 View session

Copilot finished reviewing on behalf of rolfbjarne November 28, 2025 19:03

Copilot AI reviewed Nov 28, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Dec 1, 2025

View reviewed changes

rolfbjarne added 2 commits December 4, 2025 11:33

Update docs.

bac65fe

tweak

cf99cf9

This comment has been minimized.

Sign in to view

booleans

a016155

This comment has been minimized.

Sign in to view

Boolean logic...

dafc682

This comment has been minimized.

Sign in to view

rolfbjarne and others added 2 commits December 8, 2025 18:14

Update test.

90b7214

Update tests/dotnet/UnitTests/PublishTrimmedTest.cs

c9c6484

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

[net11.0] [dotnet] Don't allow setting PublishTrimmed to any value. #24335

Are you sure you want to change the base?

[net11.0] [dotnet] Don't allow setting PublishTrimmed to any value. #24335

Conversation

rolfbjarne commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 5, 2025

💻 [CI Build #dafc682] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 8, 2025

✅ [CI Build #c9c6484] Build passed (Build packages) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 8, 2025

✅ [PR Build #c9c6484] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 8, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 8, 2025

✅ [CI Build #c9c6484] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 8, 2025

💻 [CI Build #c9c6484] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 8, 2025

💻 [CI Build #c9c6484] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 8, 2025

💻 [CI Build #c9c6484] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 8, 2025

💻 [CI Build #c9c6484] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

rolfbjarne commented Nov 28, 2025 •

edited

Loading