From 4c0caf62dee9bd028fd226f83adacffb0de2be07 Mon Sep 17 00:00:00 2001 From: Sebastien Pouliot Date: Thu, 29 Mar 2018 17:30:29 -0400 Subject: [PATCH] [mtouch] Use full path to mono-symbolicate instead of UseShellExecute (#3825) Fix https://github.com/xamarin/xamarin-macios/issues/3653 differently as `UseShellExecute` cannot be used when redirecting output so the original fix [1] caused an exception which affected it from both macOS and windows (thru XMA) instead of being an issue only with the later. It's not clear how the original [1] fix was validated successfully, it's possible than an older version of mono did not throw (since that limitation seems windows specific). [1] https://github.com/xamarin/xamarin-macios/pull/3781 --- tools/mtouch/Application.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/mtouch/Application.cs b/tools/mtouch/Application.cs index 4f83f9dd9d0a..3c8c0cedb6df 100644 --- a/tools/mtouch/Application.cs +++ b/tools/mtouch/Application.cs @@ -1481,9 +1481,9 @@ public static void CopyMSymData (string src, string dest) return; var p = new Process (); - p.StartInfo.UseShellExecute = true; + p.StartInfo.UseShellExecute = false; p.StartInfo.RedirectStandardError = true; - p.StartInfo.FileName = "mono-symbolicate"; + p.StartInfo.FileName = "/Library/Frameworks/Mono.framework/Versions/Current/Commands/mono-symbolicate"; p.StartInfo.Arguments = $"store-symbols \"{src}\" \"{dest}\""; try {