Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Juan Diego Herrera <juherrera@microsoft.com>
  • Loading branch information
jfversluis and jknaudt21 committed Feb 29, 2024
1 parent 8500b10 commit 72d74f2
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 8 deletions.
8 changes: 4 additions & 4 deletions src/Controls/Maps/src/Map.cs
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public Map() : this(new MapSpan(new Devices.Sensors.Location(20.793062527, -156.
}

/// <summary>
/// Gets or sets if scrolling by user input is enabled. Default value is <see langword="true"/>.
/// Gets or sets a value that indicates if scrolling by user input is enabled. Default value is <see langword="true"/>.
/// This is a bindable property.
/// </summary>
public bool IsScrollEnabled
Expand All @@ -81,7 +81,7 @@ public bool IsScrollEnabled
}

/// <summary>
/// Gets or sets if zooming by user input is enabled. Default value is <see langword="true"/>.
/// Gets or sets a value that indicates if zooming by user input is enabled. Default value is <see langword="true"/>.
/// This is a bindable property.
/// </summary>
public bool IsZoomEnabled
Expand All @@ -91,7 +91,7 @@ public bool IsZoomEnabled
}

/// <summary>
/// Gets or sets if the map shows an indicator of the current position of this device. Default value is <see langword="false"/>
/// Gets or sets a value that indicates if the map shows an indicator of the current position of this device. Default value is <see langword="false"/>
/// This is a bindable property.
/// </summary>
/// <remarks>Depending on the platform it is likely that runtime permission(s) need to be requested to determine the current location of the device.</remarks>
Expand All @@ -102,7 +102,7 @@ public bool IsShowingUser
}

/// <summary>
/// Gets or sets if the map shows current traffic information. Default value is <see langword="false"/>.
/// Gets or sets a value that indicates if the map shows current traffic information. Default value is <see langword="false"/>.
/// This is a bindable property.
/// </summary>
public bool IsTrafficEnabled
Expand Down
2 changes: 1 addition & 1 deletion src/Controls/Maps/src/MapElement.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
namespace Microsoft.Maui.Controls.Maps
{
/// <summary>
/// Represents an element which is visually drawn on the map control.
/// Represents an element which is visually drawn on the <see cref="Map"/> control.
/// </summary>
public partial class MapElement : Element
{
Expand Down
4 changes: 2 additions & 2 deletions src/Controls/Maps/src/Pin.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
namespace Microsoft.Maui.Controls.Maps
{
/// <summary>
/// Represents a pin on the map control.
/// Represents a pin on the <see cref="Map"/> control.
/// </summary>
public partial class Pin : Element
{
Expand Down Expand Up @@ -120,7 +120,7 @@ public override int GetHashCode()
}

/// <summary>
/// Equality operator for equals.
/// Equality operator for equals.
/// </summary>
/// <param name="left">Left to compare.</param>
/// <param name="right">Right to compare.</param>
Expand Down
4 changes: 3 additions & 1 deletion src/Core/maps/src/Core/ICircleMapElement.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ public interface ICircleMapElement : IMapElement, IFilledMapElement
/// </summary>
Location Center { get; }


/// <summary>
/// Gets the radius.
/// </summary>
Distance Radius { get; }
}
}

0 comments on commit 72d74f2

Please sign in to comment.