From 72d74f2fb22957456db8c5bea249ef683402d9bb Mon Sep 17 00:00:00 2001 From: Gerald Versluis Date: Wed, 28 Feb 2024 20:32:32 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Juan Diego Herrera --- src/Controls/Maps/src/Map.cs | 8 ++++---- src/Controls/Maps/src/MapElement.cs | 2 +- src/Controls/Maps/src/Pin.cs | 4 ++-- src/Core/maps/src/Core/ICircleMapElement.cs | 4 +++- 4 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/Controls/Maps/src/Map.cs b/src/Controls/Maps/src/Map.cs index 2b75cda93ee6..52875e5650ad 100644 --- a/src/Controls/Maps/src/Map.cs +++ b/src/Controls/Maps/src/Map.cs @@ -71,7 +71,7 @@ public Map() : this(new MapSpan(new Devices.Sensors.Location(20.793062527, -156. } /// - /// Gets or sets if scrolling by user input is enabled. Default value is . + /// Gets or sets a value that indicates if scrolling by user input is enabled. Default value is . /// This is a bindable property. /// public bool IsScrollEnabled @@ -81,7 +81,7 @@ public bool IsScrollEnabled } /// - /// Gets or sets if zooming by user input is enabled. Default value is . + /// Gets or sets a value that indicates if zooming by user input is enabled. Default value is . /// This is a bindable property. /// public bool IsZoomEnabled @@ -91,7 +91,7 @@ public bool IsZoomEnabled } /// - /// Gets or sets if the map shows an indicator of the current position of this device. Default value is + /// Gets or sets a value that indicates if the map shows an indicator of the current position of this device. Default value is /// This is a bindable property. /// /// Depending on the platform it is likely that runtime permission(s) need to be requested to determine the current location of the device. @@ -102,7 +102,7 @@ public bool IsShowingUser } /// - /// Gets or sets if the map shows current traffic information. Default value is . + /// Gets or sets a value that indicates if the map shows current traffic information. Default value is . /// This is a bindable property. /// public bool IsTrafficEnabled diff --git a/src/Controls/Maps/src/MapElement.cs b/src/Controls/Maps/src/MapElement.cs index cae15100821e..6d469f7de041 100644 --- a/src/Controls/Maps/src/MapElement.cs +++ b/src/Controls/Maps/src/MapElement.cs @@ -8,7 +8,7 @@ namespace Microsoft.Maui.Controls.Maps { /// - /// Represents an element which is visually drawn on the map control. + /// Represents an element which is visually drawn on the control. /// public partial class MapElement : Element { diff --git a/src/Controls/Maps/src/Pin.cs b/src/Controls/Maps/src/Pin.cs index 0dfb99b54426..c0a32e27b602 100644 --- a/src/Controls/Maps/src/Pin.cs +++ b/src/Controls/Maps/src/Pin.cs @@ -6,7 +6,7 @@ namespace Microsoft.Maui.Controls.Maps { /// - /// Represents a pin on the map control. + /// Represents a pin on the control. /// public partial class Pin : Element { @@ -120,7 +120,7 @@ public override int GetHashCode() } /// - /// Equality operator for equals. + /// Equality operator for equals. /// /// Left to compare. /// Right to compare. diff --git a/src/Core/maps/src/Core/ICircleMapElement.cs b/src/Core/maps/src/Core/ICircleMapElement.cs index c1c44f09c919..314f9cc3bebc 100644 --- a/src/Core/maps/src/Core/ICircleMapElement.cs +++ b/src/Core/maps/src/Core/ICircleMapElement.cs @@ -12,7 +12,9 @@ public interface ICircleMapElement : IMapElement, IFilledMapElement /// Location Center { get; } - + /// + /// Gets the radius. + /// Distance Radius { get; } } }