From c44e67037325fae744e239896867d999ea2447cf Mon Sep 17 00:00:00 2001 From: Shane Neuville Date: Mon, 12 Feb 2024 19:36:28 -0600 Subject: [PATCH] - reenable compatibility tests --- .../ControlGallery/src/Issues.Shared/BottomTabbedPageTests.cs | 1 - .../ControlGallery/src/Issues.Shared/Bugzilla29453.cs | 1 - .../ControlGallery/src/Issues.Shared/Bugzilla40704.cs | 1 - .../ControlGallery/src/Issues.Shared/Bugzilla46458.cs | 1 - .../ControlGallery/src/Issues.Shared/Bugzilla47923.cs | 1 - .../ControlGallery/src/Issues.Shared/Bugzilla51503.cs | 1 - .../src/Issues.Shared/DateTimePickerLocalizationTests.cs | 3 --- .../ControlGallery/src/Issues.Shared/GestureBubblingTests.cs | 1 - .../ControlGallery/src/Issues.Shared/Github5623.xaml.cs | 1 - .../ControlGallery/src/Issues.Shared/InputTransparentTests.cs | 3 +-- .../ControlGallery/src/Issues.Shared/Issue11224.xaml.cs | 1 - .../ControlGallery/src/Issues.Shared/Issue12574.cs | 1 - .../ControlGallery/src/Issues.Shared/Issue1975.cs | 1 - .../ControlGallery/src/Issues.Shared/Issue2266.cs | 1 - .../ControlGallery/src/Issues.Shared/Issue2767.cs | 1 - .../ControlGallery/src/Issues.Shared/Issue3319.xaml.cs | 1 - .../ControlGallery/src/Issues.Shared/Issue4356.cs | 1 - .../ControlGallery/src/Issues.Shared/Issue4597.cs | 4 ---- .../ControlGallery/src/Issues.Shared/Issue7534.cs | 1 - .../ControlGallery/src/Issues.Shared/Issue7700.cs | 1 - .../ControlGallery/src/Issues.Shared/Issue773.cs | 1 - .../ControlGallery/src/Issues.Shared/Issue8291.cs | 1 - .../ControlGallery/src/Issues.Shared/Issue9088.cs | 1 - .../ControlGallery/src/Issues.Shared/Issue968.cs | 1 - .../ControlGallery/src/Issues.Shared/Issue9827.xaml.cs | 1 - .../ControlGallery/src/UITests.Shared/Tests/EntryUITests.cs | 1 - .../src/UITests.Shared/Tests/Legacy-CellsUITests.cs | 1 - 27 files changed, 1 insertion(+), 33 deletions(-) diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/BottomTabbedPageTests.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/BottomTabbedPageTests.cs index 44a7fb3bd5f3..c8590b11e35c 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/BottomTabbedPageTests.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/BottomTabbedPageTests.cs @@ -254,7 +254,6 @@ protected override void OnPagesChanged(NotifyCollectionChangedEventArgs e) } #if UITEST && __ANDROID__ -[Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiAndroid] [Test] public async Task AddAndRemovePages() { diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla29453.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla29453.cs index 8428c3a0d59c..f76986e0bfe9 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla29453.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla29453.cs @@ -66,7 +66,6 @@ protected override void Init() } #if UITEST -[Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiAndroid] [Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiIOS] [Test] public void Bugzilla29453Test() diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla40704.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla40704.cs index a8a13d142812..32e95ebeb32a 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla40704.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla40704.cs @@ -225,7 +225,6 @@ public PatientViewModel(string code) #if UITEST -[Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiAndroid] [Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiIOS] [Test] public void Bugzilla40704HeaderPresentTest() diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla46458.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla46458.cs index d01243696181..99dd348ff678 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla46458.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla46458.cs @@ -99,7 +99,6 @@ protected override void Init() } #if UITEST -[Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiAndroid] [Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiIOS] [Test] public void GridIsEnabled() diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla47923.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla47923.cs index 522e197143ee..8bdaa4c1c51a 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla47923.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla47923.cs @@ -129,7 +129,6 @@ public LandingPage() } #if UITEST -[Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiAndroid] [Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiIOS] [Test] public void Bugzilla47923Test() diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla51503.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla51503.cs index c2c5f54f7849..72d2ec356bc8 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla51503.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla51503.cs @@ -64,7 +64,6 @@ public ChildPage() #if UITEST [Test] - [Controls.Compatibility.UITests.FailsOnMauiAndroid] public void Issue51503Test() { for (int i = 0; i < 3; i++) diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/DateTimePickerLocalizationTests.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/DateTimePickerLocalizationTests.cs index bb8450ad768a..97354f05af70 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/DateTimePickerLocalizationTests.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/DateTimePickerLocalizationTests.cs @@ -101,7 +101,6 @@ public void TimePickerOther() [Test] // Tests runs locally without issues but doesn't run successfully in a hosted agent yet [Category(UITestCategories.UwpIgnore)] - [FailsOnMauiAndroid] [FailsOnMauiIOS] public void DatePickerDMY() { @@ -122,7 +121,6 @@ public void DatePickerDMY() [Test] // Tests runs locally without issues but doesn't run successfully in a hosted agent yet [Category(UITestCategories.UwpIgnore)] - [FailsOnMauiAndroid] [FailsOnMauiIOS] public void DatePickerMissing() { @@ -140,7 +138,6 @@ public void DatePickerMissing() #if !WINDOWS [Test] - [FailsOnMauiAndroid] [FailsOnMauiIOS] public void DatePickerLetters() { diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/GestureBubblingTests.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/GestureBubblingTests.cs index d95cc8901326..9491e6a2ca41 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/GestureBubblingTests.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/GestureBubblingTests.cs @@ -35,7 +35,6 @@ public class GestureBubblingTests : TestNavigationPage static NavigationPage NavigationPage; #if UITEST -[Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiAndroid] [Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiIOS] // on iOS only menuItem=Slider, frameShouldRegisterTap=False fails [Test, TestCaseSource(nameof(TestCases))] [NUnit.Framework.Category(Compatibility.UITests.UITestCategories.UwpIgnore)] diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Github5623.xaml.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Github5623.xaml.cs index d43b9231ca6f..b1b0f9d89b6f 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Github5623.xaml.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Github5623.xaml.cs @@ -117,7 +117,6 @@ protected override void Init() #if UITEST [Test] [Compatibility.UITests.FailsOnMauiIOS] - [Compatibility.UITests.FailsOnMauiAndroid] public void CollectionViewInfiniteScroll() { RunningApp.WaitForElement("CollectionView5623"); diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/InputTransparentTests.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/InputTransparentTests.cs index cb09f61d03c4..9e345b8970d6 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/InputTransparentTests.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/InputTransparentTests.cs @@ -29,8 +29,7 @@ public class InputTransparentTests : TestNavigationPage static NavigationPage NavigationPage; #if UITEST -[Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiAndroid] -[Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiIOS] // Only menuItem=Frame fails on iOS + [Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiIOS] // Only menuItem=Frame fails on iOS [Test, TestCaseSource(nameof(TestCases))] public void VerifyInputTransparent(string menuItem) { diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue11224.xaml.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue11224.xaml.cs index 39a959834702..366633044d34 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue11224.xaml.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue11224.xaml.cs @@ -65,7 +65,6 @@ void Button_Clicked(object sender, EventArgs e) #if UITEST [Test] - [Compatibility.UITests.FailsOnMauiAndroid] [Compatibility.UITests.FailsOnMauiIOS] public void CarouselViewPositionFromVisibilityChangeTest() { diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue12574.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue12574.cs index 25e95f1ab4bd..c05e464a1aa4 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue12574.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue12574.cs @@ -123,7 +123,6 @@ public void Issue12574Test() [Test] [Compatibility.UITests.FailsOnMauiIOS] - [Compatibility.UITests.FailsOnMauiAndroid] public void RemoveItemsQuickly() { RunningApp.WaitForElement("0 item"); diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue1975.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue1975.cs index e453156c99be..d65808ef97ff 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue1975.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue1975.cs @@ -143,7 +143,6 @@ public SubItem(string text) #if UITEST [Test] [Compatibility.UITests.FailsOnMauiIOS] - [Compatibility.UITests.FailsOnMauiAndroid] public void UpdatingSourceOfDisposedListViewDoesNotCrash() { RunningApp.Tap(Go); diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue2266.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue2266.cs index 0ed5807257b0..dcf53702d032 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue2266.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue2266.cs @@ -93,7 +93,6 @@ static FlyoutPageNavigation FlyoutPageHost #if UITEST -[Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiAndroid] [Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiIOS] [Test] public void SwapMainPageWithFlyoutPages() diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue2767.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue2767.cs index ea307ee7d7bf..6bf41128f025 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue2767.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue2767.cs @@ -45,7 +45,6 @@ protected override void Init() } #if UITEST -[Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiAndroid] [Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiIOS] [Test] public void Issue2767Test() diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue3319.xaml.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue3319.xaml.cs index 35e26abf71b7..4d980392b0b6 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue3319.xaml.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue3319.xaml.cs @@ -24,7 +24,6 @@ public partial class Issue3319 : TestContentPage { #if UITEST [Test] - [Compatibility.UITests.FailsOnMauiAndroid] [Compatibility.UITests.FailsOnMauiIOS] public void Issue3319Test() { diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue4356.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue4356.cs index 139a2875f74d..c574d51b87db 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue4356.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue4356.cs @@ -23,7 +23,6 @@ namespace Microsoft.Maui.Controls.ControlGallery.Issues public partial class Issue4356 : TestContentPage { #if UITEST -[Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiAndroid] [Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiIOS] [Test] public void Issue4356Test() diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue4597.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue4597.cs index 64c9933054c7..eee697292a04 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue4597.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue4597.cs @@ -176,7 +176,6 @@ protected override void Init() #if !WINDOWS [Test] [Compatibility.UITests.FailsOnMauiIOS] - [Compatibility.UITests.FailsOnMauiAndroid] public void ImageFromFileSourceAppearsAndDisappearsCorrectly() { RunTest(nameof(Image), true); @@ -194,7 +193,6 @@ public void ImageFromUriSourceAppearsAndDisappearsCorrectly() [Test] [Compatibility.UITests.FailsOnMauiIOS] - [Compatibility.UITests.FailsOnMauiAndroid] public void ButtonFromFileSourceAppearsAndDisappearsCorrectly() { RunTest(nameof(Button), true); @@ -212,7 +210,6 @@ public void ButtonFromUriSourceAppearsAndDisappearsCorrectly() [Test] [Compatibility.UITests.FailsOnMauiIOS] - [Compatibility.UITests.FailsOnMauiAndroid] public void ImageButtonFromFileSourceAppearsAndDisappearsCorrectly() { RunTest(nameof(ImageButton), true); @@ -229,7 +226,6 @@ public void ImageButtonFromUriSourceAppearsAndDisappearsCorrectly() [Test] [Compatibility.UITests.FailsOnMauiIOS] - [Compatibility.UITests.FailsOnMauiAndroid] public void ImageCellFromFileSourceAppearsAndDisappearsCorrectly() { ImageCellTest(true); diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue7534.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue7534.cs index 98385bb38792..e4d341f38830 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue7534.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue7534.cs @@ -49,7 +49,6 @@ protected override void Init() #if UITEST && __ANDROID__ [Test] - [Compatibility.UITests.FailsOnMauiAndroid] public void ExpectingPageNotToBreak() { RunningApp.Screenshot("Test passed, label is showing as it should!"); diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue7700.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue7700.cs index 648f1d13940b..594237faf8de 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue7700.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue7700.cs @@ -142,7 +142,6 @@ ContentPage GroupedCollectionViewPage() #if UITEST [Test] - [FailsOnMauiAndroid] public void AddingItemToUnviewedCollectionViewShouldNotCrash() { RunningApp.WaitForElement(Add1); diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue773.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue773.cs index 21084546baa6..00593466cf3a 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue773.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue773.cs @@ -25,7 +25,6 @@ protected override void Init() [Test] [Issue (IssueTracker.Github, 773, "Horizontal ScrollView locks after rotation - relayout correctly after rotation", PlatformAffected.iOS)] [UiTest (typeof(ScrollView))] - [Compatibility.UITests.FailsOnMauiAndroid] public void Issue773TestsRotationRelayoutIssue () { RunningApp.SetOrientationLandscape (); diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue8291.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue8291.cs index e19f57cd831f..8e638d0b89d0 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue8291.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue8291.cs @@ -51,7 +51,6 @@ protected override void Init() #if UITEST && __ANDROID__ [Test] - [FailsOnMauiAndroid] public void ContextMenuShowsUpWhenPressAndHoldTextOnEditorAndEntryField() { RunningApp.TouchAndHold("PressEditor"); diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue9088.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue9088.cs index 7620704f576f..f622981e2bba 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue9088.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue9088.cs @@ -82,7 +82,6 @@ protected override void Init() #if UITEST && __SHELL__ [Test] - [FailsOnMauiAndroid] public void Issue9088SwipeViewConfictWithShellMenuSwipeInFromLeft() { RunningApp.WaitForElement(x => x.Marked(SwipeViewId)); diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue968.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue968.cs index 0b35267490c6..1a71c188a334 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue968.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue968.cs @@ -45,7 +45,6 @@ protected override void Init() } #if UITEST -[Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiAndroid] [Test] [Description ("Verify the layout lays out on rotations")] [UiTest (typeof(StackLayout))] diff --git a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue9827.xaml.cs b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue9827.xaml.cs index c80fc9119876..02b52ec647f4 100644 --- a/src/Compatibility/ControlGallery/src/Issues.Shared/Issue9827.xaml.cs +++ b/src/Compatibility/ControlGallery/src/Issues.Shared/Issue9827.xaml.cs @@ -50,7 +50,6 @@ protected override void OnAppearing() #if UITEST [Test] - [Compatibility.UITests.FailsOnMauiAndroid] public void Issue9827Test() { RunningApp.WaitForElement("Pos:0"); diff --git a/src/Compatibility/ControlGallery/src/UITests.Shared/Tests/EntryUITests.cs b/src/Compatibility/ControlGallery/src/UITests.Shared/Tests/EntryUITests.cs index a3ae0c0e0dff..c081f18f16e7 100644 --- a/src/Compatibility/ControlGallery/src/UITests.Shared/Tests/EntryUITests.cs +++ b/src/Compatibility/ControlGallery/src/UITests.Shared/Tests/EntryUITests.cs @@ -66,7 +66,6 @@ public override void _UnFocus() // TODO // Implement control specific ui tests - [Microsoft.Maui.Controls.Compatibility.UITests.FailsOnMauiAndroid] [Test] [UiTest(typeof(Entry), "Completed")] [Category(UITestCategories.UwpIgnore)] diff --git a/src/Compatibility/ControlGallery/src/UITests.Shared/Tests/Legacy-CellsUITests.cs b/src/Compatibility/ControlGallery/src/UITests.Shared/Tests/Legacy-CellsUITests.cs index 54d47bb65950..7dd6f9767601 100644 --- a/src/Compatibility/ControlGallery/src/UITests.Shared/Tests/Legacy-CellsUITests.cs +++ b/src/Compatibility/ControlGallery/src/UITests.Shared/Tests/Legacy-CellsUITests.cs @@ -318,7 +318,6 @@ public void CellsGalleryEntryCellTable() } [Test] - [Compatibility.UITests.FailsOnMauiAndroid] [Category(UITestCategories.Cells)] [Description("EntryCell fires .Completed event")] [UiTest(typeof(EntryCell), "Completed")]