[XamlC] Disable XamlC on non-Release builds

[StephaneDelcroix]

Description of Change

Disable XamlC (but still validate on non-Release builds

PR Checklist

• Targets the correct branch
• Tests are passing (or failures are unrelated)
• Targets a single property for a single control (or intertwined few properties)
• Adds the property to the appropriate interface
• Avoids any changes not essential to the handler property
• Adds the mapping to the PropertyMapper in the handler
• Adds the mapping method to the Android, iOS, and Standard aspects of the handler
• Implements the actual property updates (usually in extension methods in the Platform section of Core)
• Tags ported renderer methods with [PortHandler]
• Adds an example of the property to the sample project (MainPage)
• Adds the property to the stub class
• Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

• Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
• APIs that modify focusability?
• APIs that modify any text property on a control?
• Does this PR modify view nesting or view arrangement in anyway?
• Is there the smallest possibility that your PR will change accessibility?
• I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

[Redth]

How about we do False by default?

[StephaneDelcroix]

That targets file is only loaded in the Xaml.unittests context. So the default is False everywhere else

…

On 26 May 2021, at 21:39, Jonathan Dick ***@***.***> wrote:  @Redth commented on this pull request. In .nuspec/Microsoft.Maui.Controls.Debug.targets: > @@ -1,6 +1,7 @@ <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> <PropertyGroup> <MauiKeepXamlResources>True</MauiKeepXamlResources> + <_MauiForceXamlCForDebug>True</_MauiForceXamlCForDebug> How about we do False by default? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[jonathanpeppers]

Just an FYI a user can name their $(Configuration) anything. So like this wouldn't work for an AppStore configuration.

It might be better to check other properties for this like $(Optimize) or $(DebugSymbols).

You wouldn't need to check $(EmbedAssembliesIntoApk), but this is what Xamarin.Android has used for a long time:

https://github.com/xamarin/xamarin-android/blob/4ed6a222ed07551734b28525dd269d50ac107ea8/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets#L302-L323