Skip to content

Conversation

@StephaneDelcroix
Copy link
Contributor

Description of Change

Add an internal API for tooling. This is a first pass, to test the API and the utility. The values returned might need to be refined, depending on actual testing.

@chabiss

Issues Fixed

Fixes #17223

@StephaneDelcroix StephaneDelcroix added the do-not-merge Don't merge this PR label Dec 22, 2023
@StephaneDelcroix StephaneDelcroix requested a review from a team as a code owner December 22, 2023 16:38
@samhouts samhouts added the area-testing Unit tests, device tests label Jan 4, 2024
@hartez hartez removed their request for review January 10, 2024 20:27
@japarson
Copy link
Contributor

japarson commented Jan 23, 2024

I'm seeing that Shell.NavBarHasShadow defined in Styles.xaml is being classified as a Local property:
image
image

Through debugging, I'm seeing that the property is set to Local due to the following condition being met in your implementation of GetValueSource():
image

Is this expected behavior?

@japarson
Copy link
Contributor

I'm seeing that we are picking up certain properties that are not "bindable" as in there is a null BindableProperty and we cannot call GetValueSource on them:
image

The values above are from a normal Button
image

These properties also have values that are different from their default values.

Few questions:

  1. Why are these properties not bindable?
  2. What is setting their values to be different from the default?
  3. What ValueSource should these properties be considered. In WPF, we would set these properties to be Local, but that doesn't seem right here.

@StephaneDelcroix
Copy link
Contributor Author

just like in WPF where GetValueSource works only on DependencyProperty.ies, this only works on BindableProperty.ies. Dis or BPs can not be assigned by styes, triggers, bindings, dynamic resources, ... anyway, and the source is most certainly 'Local'

@StephaneDelcroix
Copy link
Contributor Author

@japarson 'Why are these properties not bindable?' which one ? anyway, that's out of the scope of this

@StephaneDelcroix StephaneDelcroix removed the do-not-merge Don't merge this PR label Mar 21, 2024
@PureWeen
Copy link
Member

/rebase

first pass on a GetSourceValue API
@PureWeen PureWeen enabled auto-merge (squash) March 21, 2024 21:35
@Redth Redth added this to the .NET 8 SR4 milestone Mar 21, 2024
@PureWeen
Copy link
Member

Test failure unrelated

@PureWeen PureWeen disabled auto-merge March 22, 2024 04:33
@PureWeen PureWeen merged commit 4c23d90 into main Mar 22, 2024
@PureWeen PureWeen deleted the GetValueSource branch March 22, 2024 04:33
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement DependencyPropertyHelper.GetValueSource just like in WPF

6 participants