[iOS] Html label not applying bold or italics #20488

kubaflo · 2024-02-10T02:07:08Z

Description of Change

HTML attributes have been disregarded when updating the text size. Therefore, a fix relies on separately updating the font size for HTML in the UpdateTextHtml extension method

Issues Fixed

Fixes #20372

Demo
Screen.Recording.2024-02-12.at.14.22.13.mov

Before	After

ghost · 2024-02-10T02:07:14Z

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

crobibero · 2024-02-11T21:39:53Z

Looks like this removes the ability to also set a font family. I used Dokdo because it is included in the sample controls app

8.0.10-nightly-10006

This branch:

rmarinho · 2024-02-12T01:57:24Z

/rebase

jsuarezruiz · 2024-02-12T07:55:26Z

src/Core/src/Platform/iOS/LabelExtensions.cs

+					if (newFont != null)
+					{
+						// Modify the font size
+						newFont = newFont.WithSize((nfloat)fontSize);


src/Core/src/Platform/iOS/LabelExtensions.cs

kubaflo · 2024-02-12T13:26:18Z

@crobibero Thank you for catching that! The device tests also found it, but it is cool that you actually tested it

kubaflo · 2024-02-12T13:36:21Z

@crobibero @jsuarezruiz demo:

Screen.Recording.2024-02-12.at.14.22.13.mov

mattleibow

Thanks for this PR and the tests! This looks good, except I notice that we have some weird mix of Controls code in Core, which I am not sure we shuld have ever gotten to. HTML text is not part of Core, so I am thinking we should avoid calling any of the related functins in Core directly. Not sure if any other folks on the team have opinions/thoughts?

mattleibow · 2024-02-12T15:10:16Z

src/Core/src/Handlers/Label/LabelHandler.iOS.cs

+			if (handler.PlatformView?.AttributedText != null)
+				handler.PlatformView?.UpdateTextHtml(label);


Not sure why this extensin method is in core as it is not used/meant to be in core. I think this should rather be done from Controls in a AppendToMapping... Then that can maybe trigger a Text changed.

@PureWeen @jsuarezruiz should this HTML extension method actually be moved to Controls so we don't start doing Controls things in Core and it is all mixed up.

Sounds good to me. @kubaflo Could you apply the changes?. Or let me know and I can do it.

jsuarezruiz · 2024-03-21T10:36:40Z

/azp run MAUI-UITests-public

azure-pipelines · 2024-03-21T10:36:53Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2024-05-10T09:31:25Z

/azp run

azure-pipelines · 2024-05-10T09:31:45Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2024-06-10T13:58:02Z

/azp run

azure-pipelines · 2024-06-10T13:58:22Z

Azure Pipelines successfully started running 3 pipeline(s).

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20372.cs

jsuarezruiz · 2024-06-13T10:10:57Z

/azp run

azure-pipelines · 2024-06-13T10:11:18Z

Azure Pipelines successfully started running 3 pipeline(s).

sscwelsh · 2024-07-08T21:03:56Z

What is the status on this? It has been open for months on the tests. I have a client that is trying to use the HTML label to display more formatting and this is the last hang up for the application to go to production

davidchieregato · 2024-09-19T12:49:44Z

it seems that this issue was completely forgotten for months

kubaflo · 2024-09-19T15:12:32Z

@sscwelsh @davidchieregato The MAUI team's priorities are not up to me, but you can have this fix in your app by following this @jfversluis's video if it is a major blocker for your migration https://www.youtube.com/watch?v=B2FOBjZKm9k&t=301s&pp=ygUWZ2VyYWxkIG1hdWkgcHIgdGVzdGluZw%3D%3D

azure-pipelines · 2024-09-19T15:21:48Z

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho · 2024-09-20T12:53:33Z

/azp run

azure-pipelines · 2024-09-20T12:53:54Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2024-10-31T12:02:45Z

/rebase

jsuarezruiz · 2024-10-31T12:03:41Z

/azp run

azure-pipelines · 2024-10-31T12:04:06Z

Azure Pipelines successfully started running 3 pipeline(s).

albilaga · 2024-11-06T06:01:04Z

src/Core/src/Platform/iOS/LabelExtensions.cs

+			attributedString.EnumerateAttributes(new NSRange(0, attributedString.Length), NSAttributedStringEnumeration.None,
+				(NSDictionary attrs, NSRange range, ref bool stop) =>
+				{
+					if (label!.Font.Family == null)


why this is only applied on default font family? What if users using custom font?

jsuarezruiz · 2024-11-27T16:18:55Z

/rebase

kubaflo requested a review from a team as a code owner February 10, 2024 02:07

kubaflo requested review from rmarinho and tj-devel709 February 10, 2024 02:07

ghost added the community ✨ Community Contribution label Feb 10, 2024

kubaflo mentioned this pull request Feb 10, 2024

HTML Label not applying Bold or Italics on iOS #20372

Open

github-actions bot force-pushed the html-label-not-applying-bold-or-italics branch from 50f4656 to c797cf6 Compare February 12, 2024 01:57

jsuarezruiz added platform/ios area-controls-label Label, Span labels Feb 12, 2024

ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Feb 12, 2024

jsuarezruiz reviewed Feb 12, 2024

View reviewed changes

src/Core/src/Platform/iOS/LabelExtensions.cs Outdated Show resolved Hide resolved

kubaflo force-pushed the html-label-not-applying-bold-or-italics branch from c797cf6 to 91f3fd6 Compare February 12, 2024 13:23

mattleibow reviewed Feb 12, 2024

View reviewed changes

kubaflo force-pushed the html-label-not-applying-bold-or-italics branch from 91f3fd6 to 3da4444 Compare April 10, 2024 22:52

Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024

jsuarezruiz reviewed Jun 11, 2024

View reviewed changes

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20372.cs Show resolved Hide resolved

jsuarezruiz self-requested a review June 13, 2024 10:10

kubaflo force-pushed the html-label-not-applying-bold-or-italics branch from e3efd4f to 5f2b4df Compare September 19, 2024 14:55

github-actions bot force-pushed the html-label-not-applying-bold-or-italics branch from 42ceadf to 73ca136 Compare October 31, 2024 12:03

albilaga reviewed Nov 6, 2024

View reviewed changes

kubaflo force-pushed the html-label-not-applying-bold-or-italics branch from 73ca136 to 5f7b08e Compare November 15, 2024 09:38

github-actions bot force-pushed the html-label-not-applying-bold-or-italics branch from 5f7b08e to b57c43c Compare November 27, 2024 16:19

Html label not applying bold or italics

44fac2e

kubaflo force-pushed the html-label-not-applying-bold-or-italics branch from b57c43c to 44fac2e Compare March 8, 2025 01:21

kubaflo self-assigned this Mar 8, 2025

		if (handler.PlatformView?.AttributedText != null)
		handler.PlatformView?.UpdateTextHtml(label);

[iOS] Html label not applying bold or italics #20488

Are you sure you want to change the base?

[iOS] Html label not applying bold or italics #20488

Uh oh!

Conversation

kubaflo commented Feb 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Issues Fixed

Uh oh!

ghost commented Feb 10, 2024

Uh oh!

crobibero commented Feb 11, 2024

Uh oh!

rmarinho commented Feb 12, 2024

Uh oh!

jsuarezruiz Feb 12, 2024

Choose a reason for hiding this comment

Uh oh!

kubaflo Feb 12, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kubaflo commented Feb 12, 2024

Uh oh!

kubaflo commented Feb 12, 2024

Uh oh!

mattleibow left a comment

Choose a reason for hiding this comment

Uh oh!

mattleibow Feb 12, 2024

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Mar 21, 2024

Uh oh!

azure-pipelines bot commented Mar 21, 2024

Uh oh!

jsuarezruiz commented May 10, 2024

Uh oh!

azure-pipelines bot commented May 10, 2024

Uh oh!

jsuarezruiz commented Jun 10, 2024

Uh oh!

azure-pipelines bot commented Jun 10, 2024

Uh oh!

Uh oh!

jsuarezruiz commented Jun 13, 2024 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines bot commented Jun 13, 2024

Uh oh!

sscwelsh commented Jul 8, 2024

Uh oh!

davidchieregato commented Sep 19, 2024

Uh oh!

kubaflo commented Sep 19, 2024

Uh oh!

azure-pipelines bot commented Sep 19, 2024

Uh oh!

rmarinho commented Sep 20, 2024

Uh oh!

azure-pipelines bot commented Sep 20, 2024

Uh oh!

jsuarezruiz commented Oct 31, 2024

Uh oh!

jsuarezruiz commented Oct 31, 2024

Uh oh!

azure-pipelines bot commented Oct 31, 2024

Uh oh!

albilaga Nov 6, 2024

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Nov 27, 2024

Uh oh!

Reviewers

Assignees

Labels

kubaflo commented Feb 10, 2024 •

edited

Loading

jsuarezruiz commented Jun 13, 2024 •

edited by jfversluis

Loading