[net9.0] Fix maui query attribute support #21061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
changed the title
This was
linked to
issues
Mar 6, 2024
Member
Author
|
/backport to release/9.0.1xx-preview2 |
Contributor
|
Started backporting to release/9.0.1xx-preview2: https://github.com/dotnet/maui/actions/runs/8177131480 |
...ontrols/src/Build.Tasks/nuget/buildTransitive/netstandard2.0/Microsoft.Maui.Controls.targets
Outdated
Show resolved
Hide resolved
…2.0/Microsoft.Maui.Controls.targets Co-authored-by: Šimon Rozsíval <simon@rozsival.com>
jonathanpeppers
approved these changes
Mar 6, 2024
Member
Author
|
/backport to release/9.0.1xx-preview2 |
Contributor
|
Started backporting to release/9.0.1xx-preview2: https://github.com/dotnet/maui/actions/runs/8186595142 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When testing some applications we found that we should enable by default the query feature.
Not sure if we should do it true by default , or just if
'$(PublishAot)' == 'true'Fixes #21032
Fixes #21033
The workaround would be to add you csproj:
<MauiQueryPropertyAttributeSupport>true</MauiQueryPropertyAttributeSupport>