Skip to content

[android] fix memory leak in TabbedPage #21218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2024
Merged

[android] fix memory leak in TabbedPage #21218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a10342
[android] fix memory leak in `TabbedPage`
jonathanpeppers Mar 14, 2024
2073d2a
[windows] skip test
jonathanpeppers Mar 15, 2024
a65144b
Somehow duplicate [Fact]
jonathanpeppers Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Controls/src/Core/Platform/Android/TabbedPageManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ internal void SetElement(TabbedPage tabbedPage)
Element.Disappearing -= OnTabbedPageDisappearing;
RemoveTabs();
_viewPager.LayoutChange -= OnLayoutChanged;
_viewPager.Adapter = null;
}

Element = tabbedPage;
Expand Down
31 changes: 31 additions & 0 deletions src/Controls/tests/DeviceTests/Elements/TabbedPage/TabbedPageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,37 @@ IEnumerator IEnumerable.GetEnumerator()
}
}

[Fact(DisplayName = "Does Not Leak"
#if WINDOWS
, Skip = "FIXME: fails on Windows"
#endif
)]
public async Task DoesNotLeak()
{
SetupBuilder();
WeakReference pageReference = null;
var navPage = new NavigationPage(new ContentPage { Title = "Page 1" });

await CreateHandlerAndAddToWindow<WindowHandlerStub>(new Window(navPage), async (handler) =>
{
var page = new TabbedPage
{
Children =
{
new ContentPage
{
Content = new VerticalStackLayout { new Label() },
}
}
};
pageReference = new WeakReference(page);
await navPage.Navigation.PushAsync(page);
await navPage.Navigation.PopAsync();
});

await AssertionExtensions.WaitForGC(pageReference);
}


TabbedPage CreateBasicTabbedPage(bool bottomTabs = false, bool isSmoothScrollEnabled = true, IEnumerable<Page> pages = null)
{
Expand Down