Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup lane to run CV2 and CV1 tests #25719

Merged
merged 10 commits into from
Nov 11, 2024
Merged

Setup lane to run CV2 and CV1 tests #25719

merged 10 commits into from
Nov 11, 2024

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Nov 6, 2024

Description of Change

Setup a lane to run just the CV2 test
I've forced a few tests to only run on a given handler because they aren't passing on the other handler. We will resolve these in upcoming PRs

Issues Fixed

Fixes #25097

@PureWeen PureWeen requested a review from a team as a code owner November 6, 2024 21:54
@jsuarezruiz jsuarezruiz added the area-testing Unit tests, device tests label Nov 7, 2024
@rmarinho
Copy link
Member

rmarinho commented Nov 7, 2024

/rebase

Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test HeaderFooterGridWorks is failing.
Snapshot different than baseline: HeaderFooterGridWorks.png (14.91% difference)
image

Seems like the footer is not rendering.

@PureWeen PureWeen requested a review from jsuarezruiz November 10, 2024 14:53
@jsuarezruiz jsuarezruiz self-assigned this Nov 11, 2024
@PureWeen
Copy link
Member Author

PureWeen commented Nov 11, 2024

  • failing tests are unrelated

@PureWeen PureWeen merged commit fad03e7 into main Nov 11, 2024
106 of 108 checks passed
@PureWeen PureWeen deleted the fix_25097 branch November 11, 2024 15:47
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing Unit tests, device tests
Projects
None yet
3 participants