Skip to content

Mark VerifyInitialEntryReturnTypeChange and VerifyGraphicsViewWithoutGrayLine tests as flaky #27776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 17, 2025
Merged

Mark VerifyInitialEntryReturnTypeChange and VerifyGraphicsViewWithoutGrayLine tests as flaky #27776

merged 3 commits into from
Feb 17, 2025

Conversation

@jfversluis
Copy link
Member

@jfversluis jfversluis commented Feb 13, 2025 •
edited
Loading

Description of Change

These tests, added/updated in #27639 and #26368 are flaky and failing with unrelated PRs. Marking these as flaky for now to see if we can make it better. cc: @HarishKumarSF4517 @devanathan-vaithiyanathan

@jfversluis jfversluis added area-testing Unit tests, device tests testing-flakiness labels Feb 13, 2025
Copilot AI review requested due to automatic review settings February 13, 2025 13:41
@jfversluis jfversluis requested a review from a team as a code owner February 13, 2025 13:41
Copilot AI reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

jsuarezruiz
jsuarezruiz suggested changes Feb 13, 2025
View reviewed changes
@jfversluis jfversluis mentioned this pull request Feb 13, 2025
Closed
@jfversluis jfversluis mentioned this pull request Feb 14, 2025
Closed
@jfversluis jfversluis changed the title Mark VerifyInitialEntryReturnTypeChange test as flaky Mark VerifyInitialEntryReturnTypeChange and VerifyGraphicsViewWithoutGrayLine tests as flaky Feb 14, 2025
@jfversluis jfversluis enabled auto-merge (squash) February 14, 2025 16:12
@jfversluis jfversluis added this to the .NET 9 SR5 milestone Feb 14, 2025
@PureWeen PureWeen force-pushed the flaky-VerifyInitialEntryReturnTypeChange branch from 192a12f to c425918 Compare February 14, 2025 22:13
jsuarezruiz
jsuarezruiz suggested changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VerifyGraphicsViewWithoutGrayLine is not marked, and is failing on Catalyst. Maybe a merge issue?

@jfversluis jfversluis merged commit 3cfe16c into main Feb 17, 2025
123 checks passed
@jfversluis jfversluis deleted the flaky-VerifyInitialEntryReturnTypeChange branch February 17, 2025 23:15
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@rmarinho rmarinho Awaiting requested review from rmarinho rmarinho was automatically assigned from dotnet/dotnet-maui-reviewers

+1 more reviewer

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-testing Unit tests, device tests testing-flakiness

Projects

MAUI SDK Ongoing
Status: Done

Milestone

.NET 9 SR5

Development

Successfully merging this pull request may close these issues.

3 participants

@jfversluis @jsuarezruiz