[Testing] Migration of Compatibility.Core platform-specific unit tests into device tests - 3 #28103

ghost · 2025-02-28T12:09:46Z

Description of Change

Migration of Compatibility.Core platform-specific unit tests to device tests. Here the migrated cases which ensuring that the IsEnabled and CornerRadius consistency of different elements matches their native counterparts. We are going to migrate tests in blocks in different PRs. This is the 3st group.

There are unit tests under:

src\Compatibility\Core\tests\Android
src\Compatibility\Core\tests\iOS
src\Compatibility\Core\tests\WinUI

That are not running right now. these cases from Xamarin.Forms where they could run as unit tests, but now with .NET MAUI this is not possible. So here I migrated the following cases in device tests.

Verification of `IsEnabled` Property:

src/Controls/tests/DeviceTests/Elements/BoxView/BoxViewTests.Android.cs: Added a test to verify that the IsEnabled property of a BoxView matches the native IsEnabled property.
src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.Android.cs: Added a test to verify that the IsEnabled property of a CheckBox matches the native IsEnabled property.
src/Controls/tests/DeviceTests/Elements/Label/LabelTests.Android.cs: Added a test to verify that the IsEnabled property of a Label matches the native IsEnabled property.
src/Controls/tests/DeviceTests/Elements/SearchBar/SearchBarTests.Android.cs: Added a test to verify that the IsEnabled property of a SearchBar matches the native IsEnabled property.
src/Controls/tests/DeviceTests/Elements/SwipeView/SwipeViewTests.Android.cs: Added a test to verify that the IsEnabled property of a SwipeView matches the native IsEnabled property.

Verification of Other Properties:

src/Controls/tests/DeviceTests/Elements/BoxView/BoxViewTests.cs: Added a test to verify that the Background property of a BoxView matches the native Background.
src/Controls/tests/DeviceTests/Elements/Button/ButtonTests.iOS.cs: Added a test to verify that the CornerRadius property of a Button matches the native CornerRadius.
src/Controls/tests/DeviceTests/Elements/RadioButton/RadioButtonTests.Windows.cs: Added a test to verify that the CornerRadius property of a RadioButton matches the native CornerRadius.

Issues Fixed

Fixes #27303

dotnet-policy-service · 2025-02-28T12:10:05Z

Hey there @anandhan-rajagopal! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copilot

PR Overview

This PR migrates a group of platform-specific unit tests from Compatibility.Core to device tests to ensure that properties like IsEnabled, Background, CornerRadius, and others are consistent with their native implementations across Android, iOS, and Windows. Key changes include:

Adding device tests for the IsEnabled property on various controls (BoxView, CheckBox, SwipeView, Editor, Label, RadioButton, SearchBar).
Introducing new tests to validate additional properties (Background for BoxView, CornerRadius for Button and RadioButton).
Updating test files to use platform-specific native view queries and assertions.

Reviewed Changes

File	Description
src/Controls/tests/DeviceTests/Elements/BoxView/BoxViewTests.Windows.cs	Added test to verify BoxView.IsEnabled against native view.
src/Controls/tests/DeviceTests/Elements/SwipeView/SwipeViewTests.Android.cs	Added test to verify SwipeView.IsEnabled against native view.
src/Controls/tests/DeviceTests/Elements/Editor/EditorTests.Android.cs	Added test confirming Editor.IsEnabled is correctly propagated.
src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.Android.cs	Added test to verify CheckBox.IsEnabled with native property, similar changes in iOS and Windows.
src/Controls/tests/DeviceTests/Elements/BoxView/BoxViewTests.Android.cs	Added test to validate BoxView.IsEnabled consistency on Android.
src/Controls/tests/DeviceTests/Elements/BoxView/BoxViewTests.cs	Added test to validate BoxView.Background consistency.
src/Controls/tests/DeviceTests/Elements/RadioButton/RadioButtonTests.Windows.cs	Added tests for both RadioButton CornerRadius and IsEnabled.
src/Controls/tests/DeviceTests/Elements/Button/ButtonTests.iOS.cs	Added test to verify Button CornerRadius against the native layer.
src/Controls/tests/DeviceTests/Elements/SearchBar/SearchBarTests.Android.cs	Added test to verify SearchBar.IsEnabled on Android.
src/Controls/tests/DeviceTests/Elements/SearchBar/SearchBarTests.Windows.cs	Added test to verify SearchBar.IsEnabled on Windows.
src/Controls/tests/DeviceTests/Elements/Label/LabelTests.Android.cs	Added test to verify Label.IsEnabled against native view.

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.Android.cs:17

[nitpick] Consider standardizing test method naming across the suite for consistency and clarity. For instance, use a naming convention like 'Verify[Element]IsEnabledProperty' consistently in all tests.

[Fact("The IsEnabled of a CheckBox should match with native IsEnabled")]

jsuarezruiz · 2025-03-03T06:43:42Z

/azp run

azure-pipelines · 2025-03-03T06:44:02Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-03-05T10:17:44Z

/rebase

jsuarezruiz · 2025-03-05T13:01:25Z

/azp run

azure-pipelines · 2025-03-05T13:01:46Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz

Could you rebase to fix the conflicts? Thanks in advance.

ghost · 2025-03-07T09:09:52Z

Could you rebase to fix the conflicts? Thanks in advance.

@jsuarezruiz Rebased and resolved the conflicts.

jsuarezruiz · 2025-03-07T11:29:38Z

/azp run

azure-pipelines · 2025-03-07T11:30:00Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-03-10T07:28:44Z

src/Controls/tests/DeviceTests/Elements/RadioButton/RadioButtonTests.Windows.cs

@@ -1,4 +1,6 @@
-using Microsoft.Maui.Handlers;
+using Microsoft.Maui.Handlers;
+using System.ComponentModel;


Maybe this is a merge issue. Appears two times.

C:\a\_work\1\s\src\Controls\tests\DeviceTests\Elements\RadioButton\RadioButtonTests.Windows.cs(5,7): error CS0105: The using directive for 'System.ComponentModel' appeared previously in this namespace [C:\a\_work\1\s\src\Controls\tests\DeviceTests\Controls.DeviceTests.csproj::TargetFramework=net9.0-windows10.0.19041.0] C:\a\_work\1\s\src\Controls\tests\DeviceTests\Elements\RadioButton\RadioButtonTests.Windows.cs(6,7): error CS0105: The using directive for 'System.Threading.Tasks' appeared previously in this namespace [C:\a\_work\1\s\src\Controls\tests\DeviceTests\Controls.DeviceTests.csproj::TargetFramework=net9.0-windows10.0.19041.0] C:\a\_work\1\s\src\Controls\tests\DeviceTests\Elements\RadioButton\RadioButtonTests.Windows.cs(28,42): error CS0103: The name 'handler' does not exist in the current context [C:\a\_work\1\s\src\Controls\tests\DeviceTests\Controls.DeviceTests.csproj::TargetFramework=net9.0-windows10.0.19041.0] C:\a\_work\1\s\src\Controls\tests\DeviceTests\Elements\RadioButton\RadioButtonTests.Windows.cs(5,7): error CS0105: The using directive for 'System.ComponentModel' appeared previously in this namespace [C:\a\_work\1\s\src\Controls\tests\DeviceTests\Controls.DeviceTests.csproj::TargetFramework=net9.0-windows10.0.20348.0] C:\a\_work\1\s\src\Controls\tests\DeviceTests\Elements\RadioButton\RadioButtonTests.Windows.cs(6,7): error CS0105: The using directive for 'System.Threading.Tasks' appeared previously in this namespace [C:\a\_work\1\s\src\Controls\tests\DeviceTests\Controls.DeviceTests.csproj::TargetFramework=net9.0-windows10.0.20348.0] C:\a\_work\1\s\src\Controls\tests\DeviceTests\Elements\RadioButton\RadioButtonTests.Windows.cs(28,42): error CS0103: The name 'handler' does not exist in the current context [C:\a\_work\1\s\src\Controls\tests\DeviceTests\Controls.DeviceTests.csproj::TargetFramework=net9.0-windows10.0.20348.0] 6 Error(s)

Could you fix the build errors?

@jsuarezruiz, Resolved the build errors and committed the changes

jsuarezruiz · 2025-03-14T12:50:32Z

/rebase

…/anandhan-rajagopal/maui into enabled-UnitTest-To-DeviceTest-1

ghost · 2025-03-21T15:40:59Z

@anandhan-rajagopal Could you fix the conflicts?

@jsuarezruiz resolved conflicts and rebased the branch

…s into device tests - 3 (#28103) * Added the CornerRadius and IsEnabled property for DeviceTest * IsEnabled property for Device tests * Addressed the feedbacks * Update BoxViewTests.cs * modified code changes * resolved windows build error * Update RadioButtonTests.Windows.cs * Update CheckBoxTests.iOS.cs * removed unwanted namespace * Update CheckBoxTests.cs * Update SwipeViewTests.Android.cs * Update BoxViewTests.Android.cs * Resolved build error in windows * Update RadioButtonTests.Windows.cs * Added the CornerRadius and IsEnabled property for DeviceTest * IsEnabled property for Device tests * Addressed the feedbacks * Update BoxViewTests.cs * modified code changes * resolved windows build error * Update RadioButtonTests.Windows.cs * Update CheckBoxTests.iOS.cs * removed unwanted namespace * Update CheckBoxTests.cs * Update SwipeViewTests.Android.cs * Resolved build error in windows * Update RadioButtonTests.Windows.cs * Update CheckBoxTests.Android.cs * Resolved conflict errors * Update BoxViewTests.Android.cs --------- Co-authored-by: nivetha-nagalingam <nivetha.nagalingam@syncfusion.com>

…s into device tests - 3 (dotnet#28103) * Added the CornerRadius and IsEnabled property for DeviceTest * IsEnabled property for Device tests * Addressed the feedbacks * Update BoxViewTests.cs * modified code changes * resolved windows build error * Update RadioButtonTests.Windows.cs * Update CheckBoxTests.iOS.cs * removed unwanted namespace * Update CheckBoxTests.cs * Update SwipeViewTests.Android.cs * Update BoxViewTests.Android.cs * Resolved build error in windows * Update RadioButtonTests.Windows.cs * Added the CornerRadius and IsEnabled property for DeviceTest * IsEnabled property for Device tests * Addressed the feedbacks * Update BoxViewTests.cs * modified code changes * resolved windows build error * Update RadioButtonTests.Windows.cs * Update CheckBoxTests.iOS.cs * removed unwanted namespace * Update CheckBoxTests.cs * Update SwipeViewTests.Android.cs * Resolved build error in windows * Update RadioButtonTests.Windows.cs * Update CheckBoxTests.Android.cs * Resolved conflict errors * Update BoxViewTests.Android.cs --------- Co-authored-by: nivetha-nagalingam <nivetha.nagalingam@syncfusion.com>

…s into device tests - 3 (#28103) * Added the CornerRadius and IsEnabled property for DeviceTest * IsEnabled property for Device tests * Addressed the feedbacks * Update BoxViewTests.cs * modified code changes * resolved windows build error * Update RadioButtonTests.Windows.cs * Update CheckBoxTests.iOS.cs * removed unwanted namespace * Update CheckBoxTests.cs * Update SwipeViewTests.Android.cs * Update BoxViewTests.Android.cs * Resolved build error in windows * Update RadioButtonTests.Windows.cs * Added the CornerRadius and IsEnabled property for DeviceTest * IsEnabled property for Device tests * Addressed the feedbacks * Update BoxViewTests.cs * modified code changes * resolved windows build error * Update RadioButtonTests.Windows.cs * Update CheckBoxTests.iOS.cs * removed unwanted namespace * Update CheckBoxTests.cs * Update SwipeViewTests.Android.cs * Resolved build error in windows * Update RadioButtonTests.Windows.cs * Update CheckBoxTests.Android.cs * Resolved conflict errors * Update BoxViewTests.Android.cs --------- Co-authored-by: nivetha-nagalingam <nivetha.nagalingam@syncfusion.com>

dotnet-policy-service bot added the community ✨ Community Contribution label Feb 28, 2025

dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Feb 28, 2025

ghost added the area-testing Unit tests, device tests label Feb 28, 2025

ghost marked this pull request as ready for review February 28, 2025 12:11

Copilot AI review requested due to automatic review settings February 28, 2025 12:11

ghost self-requested a review as a code owner February 28, 2025 12:11

ghost requested review from StephaneDelcroix and jfversluis February 28, 2025 12:11

Copilot AI reviewed Feb 28, 2025

View reviewed changes

github-actions bot force-pushed the enabled-UnitTest-To-DeviceTest-1 branch from e8839cf to 8e23646 Compare March 5, 2025 10:18

jsuarezruiz reviewed Mar 7, 2025

View reviewed changes

ghost force-pushed the enabled-UnitTest-To-DeviceTest-1 branch from 8e23646 to 4a18930 Compare March 7, 2025 09:01

jsuarezruiz suggested changes Mar 10, 2025

View reviewed changes

nivetha-nagalingam and others added 7 commits March 14, 2025 12:51

Added the CornerRadius and IsEnabled property for DeviceTest

d46967d

IsEnabled property for Device tests

effe652

Addressed the feedbacks

42fa6a5

Update BoxViewTests.cs

9186eea

modified code changes

63658a6

resolved windows build error

acb082f

Update RadioButtonTests.Windows.cs

c684def

nivetha-nagalingam and others added 16 commits March 21, 2025 20:32

IsEnabled property for Device tests

bdf9b75

Addressed the feedbacks

ca9ef6b

Update BoxViewTests.cs

9dba64f

modified code changes

921448b

resolved windows build error

f8d13ad

Update RadioButtonTests.Windows.cs

4f6c584

Update CheckBoxTests.iOS.cs

1ee071a

removed unwanted namespace

6cb730a

Update CheckBoxTests.cs

1a30db7

Update SwipeViewTests.Android.cs

d5ca4b1

Resolved build error in windows

83f89b1

Update RadioButtonTests.Windows.cs

2d2f7c9

Update CheckBoxTests.Android.cs

6539dbc

Resolved conflict errors

f2f44aa

Merge branch 'enabled-UnitTest-To-DeviceTest-1' of https://github.com…

f816bb4

…/anandhan-rajagopal/maui into enabled-UnitTest-To-DeviceTest-1

Update BoxViewTests.Android.cs

9ddf1bb

rmarinho merged commit ea04055 into dotnet:inflight/current Mar 26, 2025
1 check passed

PureWeen mentioned this pull request Apr 16, 2025

[2025/04/11] Candidate - In Flight Branch #28867

Merged

github-actions bot locked and limited conversation to collaborators Apr 26, 2025

[Testing] Migration of Compatibility.Core platform-specific unit tests into device tests - 3 #28103

[Testing] Migration of Compatibility.Core platform-specific unit tests into device tests - 3 #28103

Uh oh!

Conversation

ghost commented Feb 28, 2025

Description of Change

Verification of IsEnabled Property:

Verification of Other Properties:

Issues Fixed

Uh oh!

dotnet-policy-service bot commented Feb 28, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

PR Overview

Reviewed Changes

Uh oh!

jsuarezruiz commented Mar 3, 2025

Uh oh!

azure-pipelines bot commented Mar 3, 2025

Uh oh!

jsuarezruiz commented Mar 5, 2025

Uh oh!

jsuarezruiz commented Mar 5, 2025

Uh oh!

azure-pipelines bot commented Mar 5, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Mar 7, 2025

Uh oh!

jsuarezruiz commented Mar 7, 2025

Uh oh!

azure-pipelines bot commented Mar 7, 2025

Uh oh!

jsuarezruiz Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

ghost Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Mar 14, 2025

Uh oh!

ghost commented Mar 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Verification of `IsEnabled` Property: