Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -315,11 +315,6 @@ void Move(NotifyCollectionChangedEventArgs args)

int GetGroupCount(int groupIndex)
{
if (groupIndex < 0 || groupIndex >= _groupSource.Count)
{
return 0;
}

switch (_groupSource[groupIndex])
{
case IList list:
Expand All @@ -339,11 +334,6 @@ int GetGroupCount(int groupIndex)

object GetGroupItemAt(int groupIndex, int index)
{
if (groupIndex < 0 || groupIndex >= _groupSource.Count)
{
return -1;
}

switch (_groupSource[groupIndex])
{
case IList list:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ void Update(Action<UICollectionView> update, NotifyCollectionChangedEventArgs ar
return;

var collectionView = controller.CollectionView;
if (collectionView.Hidden || collectionView.Window == null)
if (collectionView.Hidden)
{
return;
}
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
34 changes: 0 additions & 34 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue27797.xaml

This file was deleted.

260 changes: 0 additions & 260 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue27797.xaml.cs

This file was deleted.

37 changes: 37 additions & 0 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue28098.xaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
<?xml version="1.0" encoding="utf-8" ?>
<ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
x:Class="Maui.Controls.Sample.Issues.Issue28098"
xmlns:local="clr-namespace:Maui.Controls.Sample.Issues"
Title="Issue28098">
<ContentPage.BindingContext>
<local:MainPageViewModel x:Name="_viewModel"/>
</ContentPage.BindingContext>
<StackLayout Margin="20">
<Button Clicked="Button_Clicked"
AutomationId="Button"
Text="Button"/>
<CarouselView WidthRequest="350"
HeightRequest="570"
HorizontalOptions="Fill"
VerticalOptions="Fill"
ItemsSource="{Binding Items}"
Loop="False">
<CarouselView.ItemTemplate>
<DataTemplate>
<StackLayout>
<Image Source="dotnet_bot.png"
WidthRequest="200"
HeightRequest="200"
Aspect="AspectFill"/>
<Label Padding="10"
VerticalOptions="Center"
HorizontalOptions="Center"
Text="{Binding Name}"/>
</StackLayout>
</DataTemplate>
</CarouselView.ItemTemplate>
</CarouselView>

</StackLayout>
</ContentPage>
Loading
Loading