Skip to content

Conversation

@kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Apr 8, 2025

Issues Fixed

Fixes #28821

Copilot AI review requested due to automatic review settings April 8, 2025 17:18
@kubaflo kubaflo requested a review from a team as a code owner April 8, 2025 17:18
@kubaflo kubaflo requested review from mattleibow and rmarinho April 8, 2025 17:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@kubaflo kubaflo self-assigned this Apr 8, 2025
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Apr 8, 2025
@dotnet-policy-service
Copy link
Contributor

Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@rmarinho
Copy link
Member

rmarinho commented Apr 8, 2025

/azp run

rmarinho
rmarinho previously approved these changes Apr 8, 2025
@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho
Copy link
Member

rmarinho commented Apr 8, 2025

@kubaflo can we add a test so we make sure we don t regress again, the PR that introduced this didn t fail any iOS tests :(
Screenshot 2025-04-08 at 18 35 43

@rmarinho rmarinho added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Apr 8, 2025
@rmarinho rmarinho added this to the .NET 9 SR6 milestone Apr 8, 2025
@rmarinho rmarinho moved this from Todo to Ready To Review in MAUI SDK Ongoing Apr 8, 2025
@PureWeen PureWeen added the p/0 Current heighest priority issues that we are targeting for a release. label Apr 8, 2025
@albyrock87
Copy link
Contributor

We will include a UI test soon.

`main` UITest clearly broken

image

`PR` UITest

Simulator Screen Recording - iPhone Xs - 2025-04-08 at 21 44 38

@PureWeen
Copy link
Member

PureWeen commented Apr 8, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho merged commit df738bf into dotnet:main Apr 9, 2025
122 of 128 checks passed
@github-project-automation github-project-automation bot moved this from Ready To Review to Done in MAUI SDK Ongoing Apr 9, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution p/0 Current heighest priority issues that we are targeting for a release.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

I8-The footer position is not on the far right of the horizontal grid

4 participants