[Android] Fix for the FontImageSource color is not applied properly to the Bottom Tab Icon #29317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey there @@Ahamed-Ali! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
sheiksyedm
added
area-controls-tabbedpage
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue on Android where the FontImageSource color was not applied properly to bottom tab icons in TabbedPage by using the SetIconTintList method for individual tab icons.
- Updated TabbedPageManager to apply per-item icon tinting based on the FontImageSource color.
- Added new test cases in both HostApp and Shared.Tests to validate static and dynamic scenarios.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29109.cs | Added UITests for validating the FontImageSource color fix in bottom tab icons. |
| src/Controls/tests/TestCases.HostApp/Issues/Issue29109.cs | Updated sample app with tabs that demonstrate the dynamic update of the FontImageSource color. |
| src/Controls/src/Core/Platform/Android/TabbedPageManager.cs | Modified icon tint handling to support per-item customization using SetIconTintList. |
Comments suppressed due to low confidence (1)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29109.cs:28
- [nitpick] Consider enhancing the dynamic FontImageSource color test by asserting the actual tab icon color programmatically in addition to screenshot verification to improve test precision.
App.Tap("Button");
PureWeen
added
the
p/0
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
PureWeen
approved these changes
May 23, 2025
github-project-automation
bot
moved this from Ready To Review
to Approved
in MAUI SDK Ongoing
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2025
…o the Bottom Tab Icon (#29317) * Fixed the FontImageSource Icon color issues on the BottomNavigationView Tabs * Committed the test sample and case * Added comment over the fix * Remove unnecessary space
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Root Cause of the issue
FontImageSource.Coloris not applied to the bottom tab icon in a TabbedPage.Description of Change
Additionally, the fix covers dynamic scenarios as well.
Issues Fixed
Fixes #29109
Tested the behaviour in the following platforms
Screenshot