Skip to content

Conversation

@bhavanesh2001
Copy link
Contributor

Fixes build error caused by mixed nullability handling from PRs #28568 and #29557

cc @PureWeen

@bhavanesh2001 bhavanesh2001 requested a review from a team as a code owner May 21, 2025 19:58
@bhavanesh2001 bhavanesh2001 requested review from PureWeen and tj-devel709 and removed request for a team May 21, 2025 19:58
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label May 21, 2025
@PureWeen
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@bhavanesh2001
Copy link
Contributor Author

PushingNavigationPageModallyWithShellShowsToolbarCorrectly fails with API23 #29557 (comment).
Screenshot 2025-05-22 at 6 15 31 AM

Is it okay if i add a delay in the test?

// Verify that new navigation bar can gain a back button
var secondModalPage = new ContentPage();
await modalPage.Navigation.PushAsync(secondModalPage);

@PureWeen PureWeen merged commit 16de14d into dotnet:inflight/current May 22, 2025
118 of 130 checks passed
github-actions bot pushed a commit that referenced this pull request May 22, 2025
github-actions bot pushed a commit that referenced this pull request May 30, 2025
github-actions bot pushed a commit that referenced this pull request May 30, 2025
@rmarinho rmarinho added this to the .NET 9 SR8 milestone May 30, 2025
@bhavanesh2001 bhavanesh2001 deleted the fix_build_infight/current branch May 30, 2025 21:11
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community ✨ Community Contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants