Fix Aspire ServiceDefaults project template naming #31616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
the
area-templates
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a template naming issue in the .NET MAUI Aspire Service Defaults project template where generated projects would use generic names instead of adopting the specified project name. The fix ensures proper project file naming conventions and includes comprehensive testing.
- Updated template configuration to use consistent naming patterns with proper source name placeholders
- Corrected the primary output path to match the expected project file naming structure
- Added integration tests to validate correct project naming across different naming scenarios
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Templates/src/templates/maui-aspire-servicedefaults/.template.config/template.json |
Updated defaultName, sourceName, and primaryOutputs path to fix template naming issue |
src/TestUtils/src/Microsoft.Maui.IntegrationTests/SimpleTemplateTest.cs |
Added comprehensive test to verify correct project file naming and validate template behavior |
mattleibow
approved these changes
Sep 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a template naming issue in the .NET MAUI Aspire Service Defaults project template and adds a test to ensure correct project file naming. When adding this template to your project it would not adopt the project naming, but instead would use the same generic name for each project. This PR fixes that.
Template configuration fixes:
defaultNameandsourceNameintemplate.jsonto use consistent and correct naming conventions for the project template.primaryOutputspath intemplate.jsonto match the expected project file name.Testing improvements:
AspireServiceDefaultsTemplateUsesCorrectProjectNameinSimpleTemplateTest.csto ensure that the template generates the correct project file name for various input names, and that no incorrectly named files are created.Fixes #30365