[Windows] Fix FlyoutPage test case failure on main #31896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
community ✨
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a test failure in the FlyoutPage test case on Windows by preventing the OnLoaded method from being called multiple times. The changes ensure that the IsPresented property is only applied once during the initial load, avoiding unwanted re-application when navigating between pages or changing layout behavior.
Key changes:
- Adds event unwiring logic to prevent repeated execution of OnLoaded
- Ensures consistent behavior of IsPresented property during navigation and layout changes
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
approved these changes
Oct 7, 2025
Member
|
/backport to release/9.0.1xx-sr12 |
Contributor
|
Started backporting to release/9.0.1xx-sr12: https://github.com/dotnet/maui/actions/runs/18535378993 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Fix Details
This PR is an extension of #31515 which included a fix for the IsPresented initial loading issue.
However, the changes in #31515 caused the EnsureFlyoutBehaviorChanges test to fail.
This PR provides an additional fix to resolve that test failure and ensure consistent behavior of the IsPresented property during navigation and layout mode changes.
Root Cause
When navigating to a new page and changing the FlyoutLayoutBehavior, the Loaded event fires again after returning (Pop) to the original page. Inside the OnLoaded method, the following line re-applied the IsPresented value
Description of Change
To prevent the repeated application of the IsPresented value, the Loaded event is now unwired within the method itself after execution.