Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctors to MauiMKWebView #9441

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Add ctors to MauiMKWebView #9441

merged 3 commits into from
Aug 17, 2022

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Aug 15, 2022

Description of Change

  • add ctors to MauiMkWebView so developers can apply their own WKWebViewConfiguration
  • Make the static creator for WKWebViewConfiguration public so users can make use of it to retrieve our configuration
  • Move all the code for creating MauiMkWebView into MauiMkWebView so users only have to instantiate MauiMkWebView in order for it to work instead of having to figure out what things we are setting.
  • Use WeakReference for all local instances of Handler

Issues Fixed

Fixes #9429

@PureWeen PureWeen requested a review from rmarinho August 15, 2022 14:52
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Aug 17, 2022
@jsuarezruiz jsuarezruiz added platform/iOS 🍎 and removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels Aug 17, 2022
@rmarinho rmarinho merged commit fad9463 into main Aug 17, 2022
@rmarinho rmarinho deleted the add_mauiwebview_ctors branch August 17, 2022 10:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants