From 300da79eb5ee37f705850af96b2bedfc81856c06 Mon Sep 17 00:00:00 2001
From: Drew Noakes <git@drewnoakes.com>
Date: Thu, 16 Mar 2023 13:43:13 +1100
Subject: [PATCH 1/3] .NET projects produce a reference assembly by default

In general we want to produce reference assemblies whenever possible, as they improve incremental build performance.

Making them work end-to-end requires support from other components, such as fast up-to-date checks in VS. While support was originally added for SDK-style projects, it was not present for legacy `.csproj` files. Accordingly, `ProduceReferenceAssemblies` was set `true` only when the target framework was `net5.0` or later for C#/VB projects. Similarly, F# added support during `net7.0`, so a similar check was added for F# projects.

VS 17.5 ships support for reference assemblies in the legacy CSPROJ fast up-to-date check, so all C#/VB projects are supported. Similarly, F# has full support. Consequently, it is now safe to enable the production and consumption of reference assemblies across all .NET project types, including .NET Framework, .NET Standard, .NET Core and .NET.

This commit changes the default `ProduceReferenceAssembly` value to `true` for all .NET projects.
---
 src/Tasks/Microsoft.NET.props | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/Tasks/Microsoft.NET.props b/src/Tasks/Microsoft.NET.props
index b983647d821..ce168f2ddc9 100644
--- a/src/Tasks/Microsoft.NET.props
+++ b/src/Tasks/Microsoft.NET.props
@@ -14,6 +14,16 @@ Copyright (C) Microsoft Corporation. All rights reserved.
 -->
 <Project>
 
+  <!--
+    ============================================================
+                                        Reference Assemblies
+    Enable the production of a reference assembly by all .NET projects, by default.
+    ============================================================
+  -->
+  <PropertyGroup>
+    <ProduceReferenceAssembly Condition=" '$(ProduceReferenceAssembly)' == '' ">true</ProduceReferenceAssembly>
+  </PropertyGroup>
+
   <!--
     ============================================================
                                         GetToolPaths

From 85963a04982f6fc84a00eee21bb5654fe2bf3c66 Mon Sep 17 00:00:00 2001
From: Drew Noakes <git@drewnoakes.com>
Date: Thu, 16 Mar 2023 15:13:22 +1100
Subject: [PATCH 2/3] Remove copy/paste error in header

The removed text exists in other files where it makes sense. It seems to be here due to copy/paste followed by an incomplete edit.
---
 src/Tasks/Microsoft.NET.props | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/Tasks/Microsoft.NET.props b/src/Tasks/Microsoft.NET.props
index ce168f2ddc9..59877a1cd16 100644
--- a/src/Tasks/Microsoft.NET.props
+++ b/src/Tasks/Microsoft.NET.props
@@ -7,7 +7,6 @@ WARNING:  DO NOT MODIFY this file unless you are knowledgeable about MSBuild and
           impossible to load or build your projects from the command-line or the IDE.
 
 This file contains .NET-specific properties, and items. This file is imported for .NET Core, .NET Standard, and .NET Framework projects.
-these two files are used to encapsulate the multi-targeting and framework specific build process.
 
 Copyright (C) Microsoft Corporation. All rights reserved.
 ***********************************************************************************************

From e8e0a55a114cf584e725a832b53735aa3bd3793f Mon Sep 17 00:00:00 2001
From: Drew Noakes <git@drewnoakes.com>
Date: Wed, 5 Apr 2023 10:57:11 +1000
Subject: [PATCH 3/3] ProduceOnlyReferenceAssembly and ProduceReferenceAssembly
 are mutually exclusive

---
 src/Tasks/Microsoft.NET.props | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Tasks/Microsoft.NET.props b/src/Tasks/Microsoft.NET.props
index 59877a1cd16..7ce88ca6f2a 100644
--- a/src/Tasks/Microsoft.NET.props
+++ b/src/Tasks/Microsoft.NET.props
@@ -20,7 +20,7 @@ Copyright (C) Microsoft Corporation. All rights reserved.
     ============================================================
   -->
   <PropertyGroup>
-    <ProduceReferenceAssembly Condition=" '$(ProduceReferenceAssembly)' == '' ">true</ProduceReferenceAssembly>
+    <ProduceReferenceAssembly Condition=" '$(ProduceReferenceAssembly)' == '' and '$(ProduceOnlyReferenceAssembly)' != 'true' ">true</ProduceReferenceAssembly>
   </PropertyGroup>
 
   <!--