Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add date formatting depend on period #273

Merged
merged 1 commit into from
Nov 17, 2024
Merged

add date formatting depend on period #273

merged 1 commit into from
Nov 17, 2024

Conversation

pwoltschk
Copy link
Contributor

Issue: #189

  • Ensured the x-axis dynamically adjusts to show explicit year labels for better readability.

  • Modified the chart configuration to apply a "yearly" scale for charts spanning longer periods

  • dd.MMM.yyyy for 3 - 6 months

  • MMM.yyyy for 12- 24 months

  • YYYY for 72 - 120 months

@pwoltschk
Copy link
Contributor Author

@dotnet-policy-service agree

@bruno-garcia
Copy link
Member

Thank you for your PR!

The CI failure is unrelated to your change btw. The auth token isn't available on external PRs so it's failing to run the symbol upload

@bruno-garcia bruno-garcia merged commit deb4b3d into dotnet:main Nov 17, 2024
1 of 2 checks passed
@bruno-garcia
Copy link
Member

CI running on main: https://github.com/dotnet/nuget-trends/actions/runs/11881309133/job/33105491844

@bruno-garcia
Copy link
Member

You change is live!
image

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@joaopgrassi joaopgrassi Awaiting requested review from joaopgrassi joaopgrassi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwoltschk @bruno-garcia