Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Windows/x64: 2 Regressions on 10/14/2022 1:19:37 PM #8972

Closed
performanceautofiler bot opened this issue Oct 18, 2022 · 1 comment
Closed

[Perf] Windows/x64: 2 Regressions on 10/14/2022 1:19:37 PM #8972

performanceautofiler bot opened this issue Oct 18, 2022 · 1 comment

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Oct 18, 2022

Run Information

Architecture x64
OS Windows 10.0.18362
Baseline 8bc9a0748ea2e0b28041ac48100d266aacd27108
Compare a07188777ffa92adc8a00ca974bd1c63156d19f1
Diff Diff

Regressions in System.Memory.Span<Int32>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
IndexOfValue - Duration of single invocation 25.25 ns 26.96 ns 1.07 0.14 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Memory.Span&lt;Int32&gt;*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

System.Memory.Span<Int32>.IndexOfValue(Size: 512)


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 26.96209437231738 > 25.24920520781854.
IsChangePoint: Marked as a change because one of 8/11/2022 4:03:37 AM, 8/17/2022 2:11:12 PM, 9/22/2022 3:11:11 PM, 9/27/2022 11:22:50 AM, 10/6/2022 2:13:23 PM, 10/14/2022 9:06:25 AM, 10/18/2022 1:35:00 AM falls between 10/7/2022 9:25:17 PM and 10/18/2022 1:35:00 AM.
IsRegressionStdDev: Marked as regression because -8.075029486067901 (T) = (0 -27.45398294816087) / Math.Sqrt((2.721505505947028 / (41)) + (0.1134000640802852 / (12))) is less than -2.007583770314729 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (41) + (12) - 2, .025) and -0.08813245356145978 = (25.230368654389387 - 27.45398294816087) / 25.230368654389387 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information
Architecture x64
OS Windows 10.0.18362
Baseline 8bc9a0748ea2e0b28041ac48100d266aacd27108
Compare a07188777ffa92adc8a00ca974bd1c63156d19f1
Diff Diff

Regressions in System.Collections.Concurrent.AddRemoveFromSameThreads<String>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
ConcurrentBag - Duration of single invocation 369.97 ms 402.66 ms 1.09 0.01 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Collections.Concurrent.AddRemoveFromSameThreads&lt;String&gt;*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

System.Collections.Concurrent.AddRemoveFromSameThreads<String>.ConcurrentBag(Size: 2000000)


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 402.65553 > 389.502979125.
IsChangePoint: Marked as a change because one of 10/14/2022 9:06:25 AM, 10/18/2022 1:35:00 AM falls between 10/7/2022 9:25:17 PM and 10/18/2022 1:35:00 AM.
IsRegressionStdDev: Marked as regression because -15.93634053017695 (T) = (0 -399769296.9931774) / Math.Sqrt((24822545832135.727 / (41)) + (22054272948341.027 / (12))) is less than -2.007583770314729 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (41) + (12) - 2, .025) and -0.06645190197079369 = (374859190.7937032 - 399769296.9931774) / 374859190.7937032 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@EgorBo
Copy link
Member

EgorBo commented Oct 18, 2022

indexOfValue is likely PGO update, ConcurrentBag is likely dotnet/runtime#76451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant