From 0f2da634b26a3e3e435f487ca9899e41fb344272 Mon Sep 17 00:00:00 2001 From: Parker Bibus Date: Wed, 20 Sep 2023 14:52:44 -0700 Subject: [PATCH 1/2] Normalize the dictionary and values in the run configurations for the Reporter.cs generation. Also fixed some spacing. --- src/tools/Reporting/Reporting/Reporter.cs | 2 +- src/tools/Reporting/Reporting/Run.cs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/tools/Reporting/Reporting/Reporter.cs b/src/tools/Reporting/Reporting/Reporter.cs index af8860e9645..265273de4df 100644 --- a/src/tools/Reporting/Reporting/Reporter.cs +++ b/src/tools/Reporting/Reporting/Reporter.cs @@ -67,7 +67,7 @@ private void Init() foreach (var kvp in configs.Split(';')) { var split = kvp.Split('='); - run.Configurations.Add(split[0], split[1]); + run.Configurations.Add(split[0], split[1].ToLower()); } } diff --git a/src/tools/Reporting/Reporting/Run.cs b/src/tools/Reporting/Reporting/Run.cs index 46d214bad0a..1a534cc51cf 100644 --- a/src/tools/Reporting/Reporting/Run.cs +++ b/src/tools/Reporting/Reporting/Run.cs @@ -4,7 +4,6 @@ using System; using System.Collections.Generic; -using System.Text; namespace Reporting; @@ -21,5 +20,6 @@ public class Run public string Queue { get; set; } public string WorkItemName { get; set; } - public IDictionary Configurations { get; set; } = new Dictionary(); + + public IDictionary Configurations { get; set; } = new SortedDictionary(StringComparer.OrdinalIgnoreCase); } From 13a668a4f69d479c5e32d60290f017da596618b7 Mon Sep 17 00:00:00 2001 From: Parker Bibus Date: Wed, 20 Sep 2023 16:11:02 -0700 Subject: [PATCH 2/2] Remove the ToLower() change incase any code locations rely on current casing. --- src/tools/Reporting/Reporting/Reporter.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/Reporting/Reporting/Reporter.cs b/src/tools/Reporting/Reporting/Reporter.cs index 265273de4df..af8860e9645 100644 --- a/src/tools/Reporting/Reporting/Reporter.cs +++ b/src/tools/Reporting/Reporting/Reporter.cs @@ -67,7 +67,7 @@ private void Init() foreach (var kvp in configs.Split(';')) { var split = kvp.Split('='); - run.Configurations.Add(split[0], split[1].ToLower()); + run.Configurations.Add(split[0], split[1]); } }