Use newer Roslyn API #9689
Merged
Use newer Roslyn API #9689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make private and sealed, doc and format.
drewnoakes
added
the
Feature-Language-Service
Member
Author
|
Seems there's a build error due to a problem with package availability. |
Member
|
@drewnoakes do we wait until the package is available? |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
@adamint just had to add some packages to the feed. Build is passing and this is now ready for review. |
adamint
approved these changes
Jun 25, 2025
jasonmalinowski
added a commit
to jasonmalinowski/roslyn
that referenced
this pull request
Jul 24, 2025
We offered a replacement API for them to call; this was consumed in dotnet/project-system#9689 so we can delete this now.
jasonmalinowski
added a commit
to dotnet/roslyn
that referenced
this pull request
Jul 24, 2025
We offered a replacement API for them to call; this was consumed in dotnet/project-system#9689 so we can delete this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9676
Bump a lot of packages. This brings in a newer compiler and newer analysers, which in turn require fixing up a bunch of diagnostics.
Then use the newer versions of the Roslyn APIs added for us in dotnet/roslyn#78972
Recommend reviewing commit-by-commit. Some of the wide-sweeping changes were automated codefixes and don't require as much scrutiny.
Microsoft Reviewers: Open in CodeFlow