Update Ngen Priorities for VS #11662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
approved these changes
Mar 26, 2025
Comment on lines
229
to
233
| <Ngen>$(Ngen)</Ngen> | ||
| <NgenApplication>$(NgenApplication)</NgenApplication> | ||
| <NgenArchitecture>$(NgenArchitecture)</NgenArchitecture> | ||
| <NgenPriority>$(NgenPriority)</NgenPriority> | ||
| <NgenPriority>1</NgenPriority> | ||
| </VSIXSourceItem> |
Member
There was a problem hiding this comment.
Strictly speaking this change makes all RazorNgendVSIXSourceItem items be priority 1. As it happens, there is only one of those left after some other changes, so I think we should just get rid of the entire RazorNgendVSIXSourceItem concept, above this. I think lines 226 to 233 could just be replaced with:
<VSIXSourceItem Include="$(OutputPath)Microsoft.CodeAnalysis.Razor.Compiler.dll">
<NgenPriority>1</NgenPriority>
</VSIXSourceItem>
Contributor
Author
There was a problem hiding this comment.
I got rid of the RazorNgendVSIXSourceItem, I also had to add a <Ngen>true</Ngen> in there, but the output is now identical to what it was with RazorNgendVSIXSourceItem .
This was referenced Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
We are experimenting with a mechanism to asynchronously generate important NGEN images immediately after VS setup in 17.14, and to do this are adjusting NGEN priorities of assemblies, so that the most important ones, based on JIT time, usage and user observable scenarios, are generated first. These changes are as a result of that analysis. If you have any questions on this, feel free to reach out to me or the VS Perf and Rel team.
Changes made: