Skip to content

Add remote DLL to VisualStudioCode.Extension #11776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

Add remote DLL to VisualStudioCode.Extension #11776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...icrosoft.VisualStudioCode.RazorExtension/Microsoft.VisualStudioCode.RazorExtension.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
<Content Include="$(PublishDir)\Microsoft.AspNetCore.Razor.Utilities.Shared.dll" Pack="true" PackagePath="content" CopyToOutputDirectory="PreserveNewest" />
<Content Include="$(PublishDir)\Microsoft.CodeAnalysis.Razor.Compiler.dll" Pack="true" PackagePath="content" CopyToOutputDirectory="PreserveNewest" />
<Content Include="$(PublishDir)\Microsoft.CodeAnalysis.Razor.Workspaces.dll" Pack="true" PackagePath="content" CopyToOutputDirectory="PreserveNewest" />
<Content Include="$(PublishDir)\Microsoft.CodeAnalysis.Remote.Razor.dll" Pack="true" PackagePath="content" CopyToOutputDirectory="PreserveNewest" />
Copy link
Contributor Author

@ryzngard ryzngard Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to just package everything and start excluding things instead of including....

Copy link
Contributor Author

@ryzngard ryzngard Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or find some way to test that this has the right contents

<Content Include="$(PublishDir)\Microsoft.Extensions.ObjectPool.dll" Pack="true" PackagePath="content" CopyToOutputDirectory="PreserveNewest" />

<!-- We don't need to include everything in the bin folder but we do need to add localization resources for the compiler dll -->
Expand Down