-
Notifications
You must be signed in to change notification settings - Fork 217
Improve initialization, logging, and add more features to cohosting in VS Code #11788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rovide one in VS Code
Member
DustinCampbell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
src/Razor/src/Microsoft.CodeAnalysis.Razor.CohostingShared/CohostStartupService.cs
Show resolved
Hide resolved
...or/src/Microsoft.VisualStudioCode.RazorExtension/Services/VSCodeRemoteServicesInitializer.cs
Outdated
Show resolved
Hide resolved
...zor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Completion/ISnippetCompletionItemProvider.cs
Outdated
Show resolved
Hide resolved
....CodeAnalysis.Razor.CohostingShared/Diagnostics/CohostDocumentPullDiagnosticsEndpointBase.cs
Outdated
Show resolved
Hide resolved
....CodeAnalysis.Razor.CohostingShared/Diagnostics/CohostDocumentPullDiagnosticsEndpointBase.cs
Outdated
Show resolved
Hide resolved
....CodeAnalysis.Razor.CohostingShared/Diagnostics/CohostDocumentPullDiagnosticsEndpointBase.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/IRemoteWorkspaceProvider.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/RemoteWorkspaceProvider.cs
Outdated
Show resolved
Hide resolved
...azor/src/Microsoft.VisualStudioCode.RazorExtension/Services/VSCodeRemoteWorkspaceProvider.cs
Outdated
Show resolved
Hide resolved
...azor/src/Microsoft.VisualStudioCode.RazorExtension/Services/VSCodeRemoteWorkspaceProvider.cs
Outdated
Show resolved
Hide resolved
ryzngard
approved these changes
Apr 28, 2025
DustinCampbell
approved these changes
Apr 29, 2025
src/Razor/src/Microsoft.CodeAnalysis.Razor.CohostingShared/CohostStartupService.cs
Outdated
Show resolved
Hide resolved
....CodeAnalysis.Razor.CohostingShared/Diagnostics/CohostDocumentPullDiagnosticsEndpointBase.cs
Show resolved
Hide resolved
....CodeAnalysis.Razor.CohostingShared/Diagnostics/CohostDocumentPullDiagnosticsEndpointBase.cs
Show resolved
Hide resolved
...or/src/Microsoft.CodeAnalysis.Razor.CohostingShared/RazorCohostDynamicRegistrationService.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Razor.CohostingShared/WellKnownStartupOrder.cs
Show resolved
Hide resolved
....CodeAnalysis.Razor.CohostingShared/Diagnostics/CohostDocumentPullDiagnosticsEndpointBase.cs
Show resolved
Hide resolved
DustinCampbell
approved these changes
Apr 30, 2025
This was referenced May 6, 2025
davidwengier
added a commit
that referenced
this pull request
Aug 6, 2025
Got a new ARM laptop, thought I'd try a little item from my TODO list (#11788 (comment)), ended up worse than I ever expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11759
Commit-at-a-time probably makes sense, there are a few things here
Goes with dotnet/vscode-csharp#8218