Skip to content

Conversation

@davidwengier
Copy link
Member

Part of #11759

I'm not honestly sure what I was thinking in not passing on the cancellation token. The idea of "well we might need this work later, lets run it in the background" might have made some sense (though likely not, as Roslyn essentially does the same sort of thing with its compilation tracker) but since none of the tasks here are fire and forget, nor do we want them to be, there was never any real cancellation.

It's purely anecdotal, but this seems to have fixed (or at least reduced) the amount of cancellation happening (and erroneously logged errors due to cancellation), I think because new requests would come in (or things might have been timing out) after old requests were cancelled by the client, but of course we never honoured that.

@davidwengier davidwengier requested a review from a team as a code owner May 7, 2025 08:10
@davidwengier davidwengier merged commit 8bbfe6c into dotnet:main May 9, 2025
11 checks passed
@davidwengier davidwengier deleted the MroeCohostingDocumentTweaks branch May 9, 2025 22:01
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone May 9, 2025
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants