HtmlTokenizer: Cache tokens with well-known text #11924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the green SyntaxTokens produced by the HtmlTokenizer have well-known text and can be shared.
ToddGrun
reviewed
Jun 6, 2025
src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Legacy/HtmlTokenizer.cs
Show resolved
Hide resolved
jjonescz
approved these changes
Jun 9, 2025
| return " "; | ||
| } | ||
| if (Buffer[0] == '\t') | ||
| switch (Buffer[0]) |
Member
There was a problem hiding this comment.
nit: would a switch expression (rather than statement) be more concise here?
Member
Author
There was a problem hiding this comment.
I considered that, but it requires adding another call to base.GetTokenContent(type) to avoid changing the current fall-through behavior. So, I opted for a regular switch to let the fall-through continue to work as it did before. So, it'd realistically only save 2 lines or so.
chsienki
approved these changes
Jun 9, 2025
Member
Author
|
Thanks everyone! 💖 |
This was referenced Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Razor only caches a limited number of green SyntaxTokens--specifically those that have different text, such as identifiers. However, it doesn't cache green SyntaxTokens will well-known text, even though those can always be shared if they don't have any diagnostics. This PR introduces a cache for SyntaxKind to SyntaxToken to the HTML tokenizer for tokens with well-known text.
Note: This only addresses the HTML tokenizer and C# will be handled separately. Because some SyntaxKind values are shared across HTML and C# but have different text (like SyntaxKind.Equals -- "=" in HTML and "==" in C#), it'll take a more significant change to solve this in a unified way.
CI Build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2724900&view=results
Toolset Run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2724901&view=results