ChildSyntaxList.ItemInternal optimization #11926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a port of dotnet/roslyn#73650 to Razor The general idea behind this PR is that calls to getting items in a syntax list are typically done sequentially, and thus walking the full children of a node is often not necessary. See the Roslyn PR for detailed performance analysis that was done upon the roslyn investigation. Noted that
DustinCampbell
approved these changes
Jun 8, 2025
Member
DustinCampbell
left a comment
DustinCampbell
left a comment
There was a problem hiding this comment.
Thanks for bringing this over!
Contributor
Author
|
@dotnet/razor-compiler for 2nd compiler review |
chsienki
approved these changes
Jun 9, 2025
This was referenced Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of dotnet/roslyn#73650 to Razor
The general idea behind this PR is that calls to getting items in a syntax list are typically done sequentially, and thus walking the full children of a node is often not necessary.
See the Roslyn PR for detailed performance analysis that was done upon the roslyn investigation.
In the roslyn speedometer test profile that I'm looking at, 0.8% of CPU is spent in ChildSyntaxList.ItemInternal (1.8 seconds of CPU), so this optimization is worth bringing over from Roslyn.