Reduce allocations in LegacyFileKindVisitor.VisitMarkupTagHelperAttribute #11930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bute This method shows up in the typing scenario in the razor lsp typing speedometer test as 1.8% (133MB) of allocations. This gets rid of about 1/6th of those allocations, so about a 0.3% reduction in total. Changes are limited to a single method, but are roughly: 1) Get rid of Linq WhereArrayIterator allocations by manually walking the IAs 2) Get rid of the lambda closures that these methods were taking in 3) Get rid of the loop needing to call the First(...) method and it's lambda allocation
chsienki
approved these changes
Jun 9, 2025
ToddGrun
deleted the
dev/toddgrun/ReduceAllocationsIn_LegacyFileKindVisitor.VisitMarkupTagHelperAttribute
branch
This was referenced Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce allocations in LegacyFileKindVisitor.VisitMarkupTagHelperAttribute
This method shows up in the typing scenario in the razor lsp typing speedometer test as 1.8% (133MB) of allocations. This gets rid of about 1/6th of those allocations, so about a 0.3% reduction in total.
Changes are limited to a single method, but are roughly:
*** Highlighted allocations should be removed by this change ***
