Stop spamming the activity log #11935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
approved these changes
Jun 10, 2025
Member
davidwengier
left a comment
davidwengier
left a comment
There was a problem hiding this comment.
I was going to say "we need this at least once, can we move it into the lazy", but it seems like its already there. I wonder if this was an incorrect merge, where the logging was moved but kept both.
Does "Using LSP editor" is in the activity log at least? Not that I can see why it wouldn't
Contributor
Author
I wasn't able to view the activity log when I ran with this change, but I did hit a breakpoint where we were pushing the data to the activity log, so I feel pretty comfortable it will be in there once. |
Member
|
FYI @phil-allen-msft because I'll probably forget that the string to look for in the Activity Log has changed slightly |
This was referenced Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't be doing this: