Cohost span mapping #12055
Merged
Cohost span mapping #12055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
added a commit
to dotnet/roslyn
that referenced
this pull request
Jul 28, 2025
…ts (#79604) Part of dotnet/razor#9519 Half of the fix for dotnet/razor#12054, along with the Razor side at dotnet/razor#12055 Previously I allowed rename to work on any source generated document, but made it only opt in for when the rename request came from Razor. Now that we have a little more time for development, it's time to finish the feature off properly. This PR: * Rename will only consider source generated documents if they're from Razor * Any rename operation will automatically do so, without opt in * Before applying changes to the workspace, we call in to Razor to map edits * This matches the behaviour of non-cohosting, but that does edit mapping via a document service. Since with cohosting Razor doesn't control the document creation, there is no way to set up a document service, so there is just a workspace service that does the same thing. There will still need to be more PRs to make this work in VS Code, and to hook up the span mapping aspect of the service, but I didn't want this PR to get too big.
Member
Author
|
Gonna wait for dotnet/roslyn#79677 and do this and span mapping at the same time, because I tweaked the API in the EA layer. |
chsienki
reviewed
Aug 6, 2025
| { | ||
| public static bool IsRazorSourceGeneratedDocument(this RazorGeneratedDocumentIdentity identity) | ||
| { | ||
| return identity.GeneratorTypeName == typeof(RazorSourceGenerator).FullName; |
Member
There was a problem hiding this comment.
When would we ever have a RazorGeneratedDocumentIdentity that wasn't from our source generator?
Member
Author
There was a problem hiding this comment.
When I wrote this, yeah, we could get them when, for example, you renamed a method from a Razor file, where the method was defined in C# and generated by the System.Text.Json or Regex generators. I've made recent changes in Roslyn to rename that prevents that now, but it wouldn't take much change on the Roslyn side for that to be undone.
chsienki
reviewed
Aug 6, 2025
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/WrapWithTag/RemoteSpanMappingService.cs
Outdated
Show resolved
Hide resolved
chsienki
approved these changes
Aug 6, 2025
This was referenced Aug 8, 2025
This was referenced Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12054
Part of #9519
Needs
dotnet/roslyn#79604 anddotnet/roslyn#79677 to insert before this will buildThis PR implements the workspace version of our span mapping service, since the old one is hooked up via a document service, which we can't do in cohosting.