Explicitly deny certain Roslyn formatting options #12064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToddGrun
reviewed
Aug 5, 2025
| var csharpChanges = RazorCSharpFormattingInteractionService.GetFormattedTextChanges(helper.HostWorkspaceServices, csharpRoot, csharpRoot.FullSpan, options.ToIndentationOptions(), options.CSharpSyntaxFormattingOptions, cancellationToken); | ||
| var csharpSyntaxFormattingOptions = options.CSharpSyntaxFormattingOptions.AssumeNotNull(); | ||
|
|
||
| // Roslyn can be configured to insert a space after a method call, or a dot, but that can break Razor. eg: |
Contributor
Member
Author
There was a problem hiding this comment.
Possible? Sure, it's just code :)
Off the top of my head I can think of 3 approaches:
- Add something cool like
#pragma formatter disable SpaceBeforeMethodCallto Roslyn - Use the C# parser to go through the formatted expressions after the fact and remove significant whitespace
- Do a two-pass format, one with the user options, one for just implicit expressions with these modified options
All 3 sound like they're beyond this PR, and personally I think I'd wait until someone complains about the formatting not honouring their settings before we action it (assuming when they complain, we remember that this quirk exists)
chsienki
approved these changes
Aug 6, 2025
This was referenced Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12053