Reduce the range walked for formatting content validation #12384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this validation pass would walk over the whole content of the original and changed texts. This change modifies it instead to walk over the affected ranges in the original and changed texts based on the given set of changes.
DustinCampbell
approved these changes
Oct 23, 2025
davidwengier
approved these changes
Oct 23, 2025
Member
davidwengier
left a comment
davidwengier
left a comment
There was a problem hiding this comment.
It took me a while to reason about var changedEnd = textEnd + (changedText.Length - text.Length); but I think this makes sense. Hopefully the volume of our formatting tests prove it too :)
This was referenced Oct 24, 2025
This was referenced Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this validation pass would walk over the whole content of the original and changed texts. This change modifies it instead to walk over the affected ranges in the original and changed texts based on the given set of changes.